Open Stack

On 8/18/20 10:03 AM, Cédric Jeanneret wrote:
> 
> 
> On 8/18/20 9:53 AM, Rabi Mishra wrote:
>>
>>
>> On Tue, Aug 18, 2020 at 1:07 PM Cédric Jeanneret <cjeanner at redhat.com
>> <mailto:cjeanner at redhat.com>> wrote:
>>
>>     Hello there!
>>
>>     I'm wondering if we could move the "tripleo-ansible-inventory" script
>>     from the tripleo-validations repo to tripleo-common.
>>
>>
>> TBH, I don't know the history, but it would be better if we remove all
>> scripts from tripleo-common and use it just as a utility library (now
>> that Mistral is gone). Most of the existing scripts probably have an
>> existing command in tripleoclient. We can implement  missing ones
>> including "tripleo-ansible-inventory" in python-tripleoclient.

hm, we can't really replace it imho, since it's used as a "dynamic
inventory" for ansible directly.
The best thing we can probably do is:
- add "--os-cloud" option support[1]
- move this script to tripleoclient (I agree with you regarding
tripleo-common)

Once this is done, *maybe* we can move things to tripleoclient itself,
but we'll need to do something in order to keep that script in place
anyway...

[1] Thanks Mathieu :) https://review.opendev.org/747140


> 
> would probably be better to implement it directly in tripleoclient imho.
> In any cases, it has nothing to do in tripleo-validations...
> 
> I can't connect to launchpad, they are having some auth issue, I can't
> create an RFE there :(.
> 
>>
>>
>>     The main motivation here is to make things consistent:
>>     - that script calls content from tripleo-common, nothing from
>>     tripleo-validations.
>>     - that script isn't only for the validations, so it makes more sense to
>>     install it via tripleo-common
>>     - in fact, we should probably push that inventory thing as an `openstack
>>     tripleo' sub-command, but that's another story
>>
>>     So, is there any opposition to this proposal?
>>
>>     Cheers,
>>
>>     C.
>>
>>
>>     -- 
>>     Cédric Jeanneret (He/Him/His)
>>     Sr. Software Engineer - OpenStack Platform
>>     Deployment Framework TC
>>     Red Hat EMEA
>>     https://www.redhat.com/
>>
>>
>>
>> -- 
>> Regards,
>> Rabi Mishra
>>
> 

-- 
Cédric Jeanneret (He/Him/His)
Sr. Software Engineer - OpenStack Platform
Deployment Framework TC
Red Hat EMEA
https://www.redhat.com/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20200820/93c9f8eb/attachment.sig>