[infra] Patch submitters can remove core reviewer votes?

Ben Nemec openstack at nemebean.com
Tue Feb 19 16:36:00 UTC 2019



On 2/19/19 10:13 AM, Jeremy Stanley wrote:
> On 2019-02-19 10:03:39 -0600 (-0600), Ben Nemec wrote:
>> See https://review.openstack.org/#/c/637703/
>>
>> I'm assuming in that case it was an accident, but it doesn't seem like this
>> should be possible at all. For example, if I had -2'd would it still have
>> allowed the removal? Maybe you can only remove positive votes?
> 
> The latter, yes:
> 
> https://review.openstack.org/Documentation/access-control.html#category_remove_reviewer
> 
>> Anyway, seemed weird to me so I thought I would bring it up.
> 
> Thanks for doing so. It's a sometimes surprising behavior worth
> keeping in mind!
> 

Yeah, definitely made me o.O when I saw it. :-)

Thanks!



More information about the openstack-discuss mailing list