Open Stack

On 31/12/2019 01.10, Akihiro Motoki wrote:
> On Mon, Dec 30, 2019 at 10:58 PM Andreas Jaeger <aj at suse.com> wrote:
>>
>> On 28/12/2019 21.24, Akihiro Motoki wrote:
>>> [...]
>>> (side note)
>>> django-babel is not a runtime requirement of horizon. It is just used
>>> when we extract
>>> translation strings and the current user is the infra translation jobs
>>> [4], so I think we don't
>>> need to care co-installability much. It can be moved to
>>> test-requirements.txt in horizon
>>> and we can install django-babel/enmerkar explicitly in
>>> common_translation_update.sh in [4].
>>
>> How will you support stable branches?
>>
>> As you know, the change needs to work with all branches we have
>> translations on,
> 
> What in my mind is just to move django-babel/enmerkar to
> test-requirements.txt in the master (ussuri).
> project-config is branchless, so I believe it is enough to make the
> following change in install_horizon().
> Doesn't it work?
> 
>  (cd ${HORIZON_DIR} && pip install -c $UPPER_CONSTRAINTS_FILE .)
> to
>   (cd ${HORIZON_DIR} && pip install -c $UPPER_CONSTRAINTS_FILE . &&
> pip install -c $UPPER_CONSTRAINTS_FILE test-requirements.txt)

That should work - too simple ;)

Andreas
-- 
 Andreas Jaeger aj at suse.com Twitter: jaegerandi
  SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, D 90409 Nürnberg
   (HRB 36809, AG Nürnberg) GF: Felix Imendörffer
    GPG fingerprint = EF18 1673 38C4 A372 86B1  E699 5294 24A3 FF91 2ACB