[requirements][os-ken][neutron] update of tinyrpc from 1.0.3 to 1.0.4 breaks neutron-grenade

Matthew Thode mthode at mthode.org
Tue Dec 3 08:06:25 UTC 2019


On 19-12-03 09:02:40, Slawek Kaplonski wrote:
> Hi,
> 
> I opened story board for this [1] but it seems for me that this isn’t os-ken problem. It seems that version 1.0.4 of tinyrpc is not compatible with python 2.7 and this is failing because of [2].
> Neutron-grenade job is old py27 job which I already proposed to remove. See [3] for details. So IMO we should simply wait a bit more, remove this old py27 job and than we should be good with new tinyrpc version.
> 
> [1] https://storyboard.openstack.org/#!/story/2006975
> [2] https://github.com/mbr/tinyrpc/commit/e67c368dd65e03a055d93f38d313d97e69092920
> [3] https://review.opendev.org/#/q/owner:%22Slawek+Kaplonski%22+branch:master+topic:drop-py27-support
> 
> > On 2 Dec 2019, at 16:16, Matthew Thode <mthode at mthode.org> wrote:
> > 
> > The only explicit depenency I can find is for os-ken
> > 
> > +--------------------------------------------------+----------------------------------------------------------+------+----------------------------------------------------+
> > | Repository                                       | Filename                                                 | Line | Text                                               |
> > +--------------------------------------------------+----------------------------------------------------------+------+----------------------------------------------------+
> > | openstack/os-ken                                 | requirements.txt                                         |   13 | tinyrpc>=0.6  # RPC library, BGP speaker(net_cntl) |
> > | openstack/requirements                           | openstack_requirements/tests/files/upper-constraints.txt |  187 | tinyrpc===0.5                                      |
> > | openstack/upstream-institute-virtual-environment | elements/upstream-training/static/tmp/requirements.txt   |  292 | tinyrpc==1.0.3                                     |
> > +--------------------------------------------------+----------------------------------------------------------+------+----------------------------------------------------+
> > 
> > Though it's included in constraints for a bunch of neutron packages though lower-constraints.txt
> > 
> > +--------------------------------------------------+----------------------------------------------------------+------+----------------------------------------------------+
> > | Repository                                       | Filename                                                 | Line | Text                                               |
> > +--------------------------------------------------+----------------------------------------------------------+------+----------------------------------------------------+
> > | openstack/dragonflow                             | lower-constraints.txt                                    |  151 | tinyrpc==0.8                                       |
> > | openstack/networking-bagpipe                     | lower-constraints.txt                                    |  143 | tinyrpc==0.6                                       |
> > | openstack/networking-baremetal                   | lower-constraints.txt                                    |  139 | tinyrpc==0.8                                       |
> > | openstack/networking-bgpvpn                      | lower-constraints.txt                                    |  165 | tinyrpc==0.6                                       |
> > | openstack/networking-generic-switch              | lower-constraints.txt                                    |  134 | tinyrpc==0.6                                       |
> > | openstack/networking-hyperv                      | lower-constraints.txt                                    |  131 | tinyrpc==0.6                                       |
> > | openstack/networking-l2gw                        | lower-constraints.txt                                    |  137 | tinyrpc==0.6                                       |
> > | openstack/networking-odl                         | lower-constraints.txt                                    |  192 | tinyrpc==0.8                                       |
> > | openstack/networking-ovn                         | lower-constraints.txt                                    |  145 | tinyrpc==0.6                                       |
> > | openstack/networking-powervm                     | lower-constraints.txt                                    |  138 | tinyrpc==0.6                                       |
> > | openstack/networking-sfc                         | lower-constraints.txt                                    |  146 | tinyrpc==0.8                                       |
> > | openstack/neutron                                | lower-constraints.txt                                    |  147 | tinyrpc==0.6                                       |
> > | openstack/neutron-dynamic-routing                | lower-constraints.txt                                    |  141 | tinyrpc==0.6                                       |
> > | openstack/neutron-fwaas                          | lower-constraints.txt                                    |  141 | tinyrpc==0.6                                       |
> > | openstack/neutron-vpnaas                         | lower-constraints.txt                                    |  144 | tinyrpc==0.6                                       |
> > | openstack/os-ken                                 | lower-constraints.txt                                    |  144 | tinyrpc==0.6                                       |
> > | openstack/os-ken                                 | requirements.txt                                         |   13 | tinyrpc>=0.6  # RPC library, BGP speaker(net_cntl) |
> > | openstack/requirements                           | openstack_requirements/tests/files/upper-constraints.txt |  187 | tinyrpc===0.5                                      |
> > | openstack/requirements                           | upper-constraints.txt                                    |  270 | tinyrpc===1.0.3                                    |
> > | openstack/tricircle                              | lower-constraints.txt                                    |  149 | tinyrpc==0.6                                       |
> > | openstack/upstream-institute-virtual-environment | elements/upstream-training/static/tmp/requirements.txt   |  292 | tinyrpc==1.0.3                                     |
> > | x/flame                                          | upper-constraints.txt                                    |  208 | tinyrpc===0.9.3                                    |
> > | x/networking-arista                              | lower-constraints.txt                                    |  146 | tinyrpc==0.6                                       |
> > | x/networking-fujitsu                             | lower-constraints.txt                                    |  142 | tinyrpc==0.8                                       |
> > | x/networking-omnipath                            | lower-constraints.txt                                    |  144 | tinyrpc==0.6                                       |
> > | x/networking-opencontrail                        | lower-constraints.txt                                    |  149 | tinyrpc==0.6                                       |
> > | x/networking-vsphere                             | lower-constraints.txt                                    |  142 | tinyrpc==0.6                                       |
> > | x/neutron-interconnection                        | lower-constraints.txt                                    |  145 | tinyrpc==0.6                                       |
> > | x/tap-as-a-service                               | lower-constraints.txt                                    |  139 | tinyrpc==0.8                                       |
> > +--------------------------------------------------+----------------------------------------------------------+------+----------------------------------------------------+
> > 
> > https://github.com/mbr/tinyrpc/compare/1.0.3...1.0.4 isn't too big but does seem to have a refactor in it.
> > 
> > If you want to depend on a requirements patch for testing, I've created https://review.opendev.org/692915
> > for testing the update.
> > 
> > Thanks,
> > 
> > -- 
> > Matthew Thode
> 
>> Slawek Kaplonski
> Senior software engineer
> Red Hat
> 

Your right, I forgot about that, thanks for the reminder.

-- 
Matthew Thode
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20191203/f24bfbaf/attachment.sig>


More information about the openstack-discuss mailing list