Open Stack

Lance Bragstad <lbragstad at gmail.com> writes:

> Keystone is failing because it's missing a fix from oslo.messaging [0].
> That said, keystone is also relying on an internal implementation detail in
> oslo.messaging by mocking it in tests [1]. The notification work has been
> around in keystone for a *long* time, but it's apparent that we should
> revisit these tests to make sure we aren't testing something that is
> already tested by oslo.messaging if we're mocking internal implementation
> details of a library.
>
> Regardless, blacklisting version 9.0.0 will work for keystone, but we can
> work around it another way by either rewriting the tests to not care about
> oslo.messaging specifics, or removing them if they're obsolete.

Yeah, we keep running into these sorts of problems when folks mock past
the public API boundary of a library, so let's eliminate them as we find
them.

If there's a way to add a fixture to oslo.messaging to support the tests
we can do that, too.

Doug

>
> [0] https://review.openstack.org/#/c/608196/
> [1]
> https://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/common/test_notifications.py#n1343
>
> On Mon, Oct 8, 2018 at 10:59 PM Matthew Thode <prometheanfire at gentoo.org>
> wrote:
>
>> several projects have had problems with the new release, some have ways
>> of working around it, and some do not.  I'm sending this just to raise
>> the issue and allow a place to discuss solutions.
>>
>> Currently there is a review proposed to blacklist 9.0.0, but if this is
>> going to still be an issue somehow in further releases we may need
>> another solution.
>>
>> https://review.openstack.org/#/c/608835/
>>
>> --
>> Matthew Thode (prometheanfire)
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev