Open Stack

On 5/29/2018 2:06 PM, Artom Lifshitz wrote:
>> On Tue, May 29, 2018 at 10:52:04AM -0400, Mohammed Naser wrote:
>>
>> :On Tue, May 29, 2018 at 10:43 AM, Artom Lifshitz <alifshit at redhat.com> wrote:
>> :>  One idea would be that, once the meat of the patch
>> :> has passed multiple rounds of reviews and looks good, and what remains
>> :> is only nits, the reviewer themselves take on the responsibility of
>> :> pushing a new patch that fixes the nits that they found.
>>
>> Doesn't the above suggestion sufficiently address the concern below?
>>
>> :I'd just like to point out that what you perceive as a 'finished
>> :product that looks unprofessional' might be already hard enough for a
>> :contributor to achieve.  We have a lot of new contributors coming from
>> :all over the world and it is very discouraging for them to have their
>> :technical knowledge and work be categorized as 'unprofessional'
>> :because of the language barrier.
>> :
>> :git-nit and a few minutes of your time will go a long way, IMHO.
>>
>> As very intermittent contributor and native english speaker with
>> relatively poor spelling and typing I'd be much happier with a
>> reviewer pushing a patch that fixes nits rather than having a ton of
>> inline comments that point them out.
>>
>> maybe we're all saying the same thing here?
> Yeah, I feel like we're all essentially in agreement that nits (of the
> English mistake of typo type) do need to get fixed, but sometimes
> (often?) putting the burden of fixing them on the original patch
> contributor is neither fair nor constructive.
I am ok with this statement if we are all in agreement that doing 
follow-up patches is an acceptable practice.

> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev