Open Stack

Hi All,

Problem description:

Monty Taylor added split-logger functionality in patch[1].
This functionality splits logs in four different logs:

*         keystoneauth.session.request

*         keystoneauth.session.response

*         keystoneauth.session.body

*         keystoneauth.session.request-id

Working on enabling this split_logger functionality for cinder to its internal clients interaction (like glanceclient, keystoneclient, novaclient).

Steps followed to enable this functionality:

1. Register the configuration option 'split_loggers' in keystoneauth [2].

2. After registering 'split_loggers' option in keystoneauth for cinder to novaclient interaction, need to set value of 'split_loggers=True/False' under [nova] section of cinder.conf, so that this 'split_loggers' value will get loaded from [nova] section at the time of loading session [3].

So trying same approach for cinder to glanceclient interaction, but there is one difference:
                glanceclient uses 'load_from_options' method [4] while loading session
                And novaclient is using 'load_session_from_conf_options' method[3] from keystoneauth.

Impact:

For this need to register the session conf options from keystoneauth under [glance] section which earlier was under [default] section.
Please refer changes made for this[5].

Pros of using this approach:


1.       As we are setting conf option in keystoneauth it will directly load value of 'split_loggers' from conf file.
So no need to pass explicitly 'split_loggers' value at the time of loading keystoneauth session.

Cons of using this approch:

1.       Need to register session conf options under [glance] section instead of [default].

Need opinion on this as it is changing the group from [default] to [glance] for session conf options.

[1]: https://review.openstack.org/#/c/505764/
[2]: http://paste.openstack.org/show/721071/
[3]: https://github.com/openstack/cinder/blob/master/cinder/compute/nova.py#L112
[4]: https://github.com/openstack/cinder/blob/master/cinder/image/glance.py#L104
[5]: http://paste.openstack.org/show/721095/

Disclaimer: This email and any attachments are sent in strictest confidence for the sole use of the addressee and may contain legally privileged,confidential, and proprietary data. If you are not the intended recipient,please advise the sender by replying promptly to this email and then delete and destroy this email and any attachments without any further use, copying or forwarding.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180517/a97d5743/attachment.html>