Open Stack

Hi Ivan & Horizon folks


AFAIK, Horizon team had conclusion that you will add the specific
members to xstatic-core, correct ?
Can I ask you to add the following members ?
# All of tree are heat-dashboard core.

Kazunori Shinohara / ksnhr.tech at gmail.com #myself
Xinni Ge / xinni.ge1990 at gmail.com
Keiichi Hikita / keiichi.hikita at gmail.com

Please give me a shout, if we are not on same page or any concern.

Regards,
Kaz


2018-03-21 22:29 GMT+09:00 Kaz Shinohara <ksnhr.tech at gmail.com>:
> Hi Ivan, Akihiro,
>
>
> Thanks for your kind arrangement.
> Looking forward to hearing your decision soon.
>
> Regards,
> Kaz
>
> 2018-03-21 21:43 GMT+09:00 Ivan Kolodyazhny <e0ne at e0ne.info>:
>> HI Team,
>>
>> From my perspective, I'm OK both with #2 and #3 options. I agree that #4
>> could be too complicated for us. Anyway, we've got this topic on the meeting
>> agenda [1] so we'll discuss it there too. I'll share our decision after the
>> meeting.
>>
>> [1] https://wiki.openstack.org/wiki/Meetings/Horizon
>>
>>
>>
>> Regards,
>> Ivan Kolodyazhny,
>> http://blog.e0ne.info/
>>
>> On Tue, Mar 20, 2018 at 10:45 AM, Akihiro Motoki <amotoki at gmail.com> wrote:
>>>
>>> Hi Kaz and Ivan,
>>>
>>> Yeah, it is worth discussed officially in the horizon team meeting or the
>>> mailing list thread to get a consensus.
>>> Hopefully you can add this topic to the horizon meeting agenda.
>>>
>>> After sending the previous mail, I noticed anther option. I see there are
>>> several options now.
>>> (1) Keep xstatic-core and horizon-core same.
>>> (2) Add specific members to xstatic-core
>>> (3) Add specific horizon-plugin core to xstatic-core
>>> (4) Split core membership into per-repo basis (perhaps too complicated!!)
>>>
>>> My current vote is (2) as xstatic-core needs to understand what is xstatic
>>> and how it is maintained.
>>>
>>> Thanks,
>>> Akihiro
>>>
>>>
>>> 2018-03-20 17:17 GMT+09:00 Kaz Shinohara <ksnhr.tech at gmail.com>:
>>>>
>>>> Hi Akihiro,
>>>>
>>>>
>>>> Thanks for your comment.
>>>> The background of my request to add us to xstatic-core comes from
>>>> Ivan's comment in last PTG's etherpad for heat-dashboard discussion.
>>>>
>>>> https://etherpad.openstack.org/p/heat-dashboard-ptg-rocky-discussion
>>>> Line135, "we can share ownership if needed - e0ne"
>>>>
>>>> Just in case, could you guys confirm unified opinion on this matter as
>>>> Horizon team ?
>>>>
>>>> Frankly speaking I'm feeling the benefit to make us xstatic-core
>>>> because it's easier & smoother to manage what we are taking for
>>>> heat-dashboard.
>>>> On the other hand, I can understand what Akihiro you are saying, the
>>>> newly added repos belong to Horizon project & being managed by not
>>>> Horizon core is not consistent.
>>>> Also having exception might make unexpected confusion in near future.
>>>>
>>>> Eventually we will follow your opinion, let me hear Horizon team's
>>>> conclusion.
>>>>
>>>> Regards,
>>>> Kaz
>>>>
>>>>
>>>> 2018-03-20 12:58 GMT+09:00 Akihiro Motoki <amotoki at gmail.com>:
>>>> > Hi Kaz,
>>>> >
>>>> > These repositories are under horizon project. It looks better to keep
>>>> > the
>>>> > current core team.
>>>> > It potentially brings some confusion if we treat some horizon plugin
>>>> > team
>>>> > specially.
>>>> > Reviewing xstatic repos would be a small burden, wo I think it would
>>>> > work
>>>> > without problem even if only horizon-core can approve xstatic reviews.
>>>> >
>>>> >
>>>> > 2018-03-20 10:02 GMT+09:00 Kaz Shinohara <ksnhr.tech at gmail.com>:
>>>> >>
>>>> >> Hi Ivan, Horizon folks,
>>>> >>
>>>> >>
>>>> >> Now totally 8 xstatic-** repos for heat-dashboard have been landed.
>>>> >>
>>>> >> In project-config for them, I've set same acl-config as the existing
>>>> >> xstatic repos.
>>>> >> It means only "xstatic-core" can manage the newly created repos on
>>>> >> gerrit.
>>>> >> Could you kindly add "heat-dashboard-core" into "xstatic-core" like as
>>>> >> what horizon-core is doing ?
>>>> >>
>>>> >> xstatic-core
>>>> >> https://review.openstack.org/#/admin/groups/385,members
>>>> >>
>>>> >> heat-dashboard-core
>>>> >> https://review.openstack.org/#/admin/groups/1844,members
>>>> >>
>>>> >> Of course, we will surely touch only what we made, just would like to
>>>> >> manage them smoothly by ourselves.
>>>> >> In case we need to touch the other ones, will ask Horizon team for
>>>> >> help.
>>>> >>
>>>> >> Thanks in advance.
>>>> >>
>>>> >> Regards,
>>>> >> Kaz
>>>> >>
>>>> >>
>>>> >> 2018-03-14 15:12 GMT+09:00 Xinni Ge <xinni.ge1990 at gmail.com>:
>>>> >> > Hi Horizon Team,
>>>> >> >
>>>> >> > I reported a bug about lack of ``ADD_XSTATIC_MODULES`` plugin
>>>> >> > option,
>>>> >> >  and submitted a patch for it.
>>>> >> > Could you please help to review the patch.
>>>> >> >
>>>> >> > https://bugs.launchpad.net/horizon/+bug/1755339
>>>> >> > https://review.openstack.org/#/c/552259/
>>>> >> >
>>>> >> > Thank you very much.
>>>> >> >
>>>> >> > Best Regards,
>>>> >> > Xinni
>>>> >> >
>>>> >> > On Tue, Mar 13, 2018 at 6:41 PM, Ivan Kolodyazhny <e0ne at e0ne.info>
>>>> >> > wrote:
>>>> >> >>
>>>> >> >> Hi Kaz,
>>>> >> >>
>>>> >> >> Thanks for cleaning this up. I put +1 on both of these patches
>>>> >> >>
>>>> >> >> Regards,
>>>> >> >> Ivan Kolodyazhny,
>>>> >> >> http://blog.e0ne.info/
>>>> >> >>
>>>> >> >> On Tue, Mar 13, 2018 at 4:48 AM, Kaz Shinohara
>>>> >> >> <ksnhr.tech at gmail.com>
>>>> >> >> wrote:
>>>> >> >>>
>>>> >> >>> Hi Ivan & Horizon folks,
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> Now we are submitting a couple of patches to have the new xstatic
>>>> >> >>> modules.
>>>> >> >>> Let me request you to have review the following patches.
>>>> >> >>> We need Horizon PTL's +1 to move these forward.
>>>> >> >>>
>>>> >> >>> project-config
>>>> >> >>> https://review.openstack.org/#/c/551978/
>>>> >> >>>
>>>> >> >>> governance
>>>> >> >>> https://review.openstack.org/#/c/551980/
>>>> >> >>>
>>>> >> >>> Thanks in advance:)
>>>> >> >>>
>>>> >> >>> Regards,
>>>> >> >>> Kaz
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> 2018-03-12 20:00 GMT+09:00 Radomir Dopieralski
>>>> >> >>> <openstack at sheep.art.pl>:
>>>> >> >>> > Yes, please do that. We can then discuss in the review about
>>>> >> >>> > technical
>>>> >> >>> > details.
>>>> >> >>> >
>>>> >> >>> > On Mon, Mar 12, 2018 at 2:54 AM, Xinni Ge
>>>> >> >>> > <xinni.ge1990 at gmail.com>
>>>> >> >>> > wrote:
>>>> >> >>> >>
>>>> >> >>> >> Hi, Akihiro
>>>> >> >>> >>
>>>> >> >>> >> Thanks for the quick reply.
>>>> >> >>> >>
>>>> >> >>> >> I agree with your opinion that BASE_XSTATIC_MODULES should not
>>>> >> >>> >> be
>>>> >> >>> >> modified.
>>>> >> >>> >> It is much better to enhance horizon plugin settings,
>>>> >> >>> >>  and I think maybe there could be one option like
>>>> >> >>> >> ADD_XSTATIC_MODULES.
>>>> >> >>> >> This option adds the plugin's xstatic files in
>>>> >> >>> >> STATICFILES_DIRS.
>>>> >> >>> >> I am considering to add a bug report to describe it at first,
>>>> >> >>> >> and
>>>> >> >>> >> give
>>>> >> >>> >> a
>>>> >> >>> >> patch later maybe.
>>>> >> >>> >> Is that ok with the Horizon team?
>>>> >> >>> >>
>>>> >> >>> >> Best Regards.
>>>> >> >>> >> Xinni
>>>> >> >>> >>
>>>> >> >>> >> On Fri, Mar 9, 2018 at 11:47 PM, Akihiro Motoki
>>>> >> >>> >> <amotoki at gmail.com>
>>>> >> >>> >> wrote:
>>>> >> >>> >>>
>>>> >> >>> >>> Hi Xinni,
>>>> >> >>> >>>
>>>> >> >>> >>> 2018-03-09 12:05 GMT+09:00 Xinni Ge <xinni.ge1990 at gmail.com>:
>>>> >> >>> >>> > Hello Horizon Team,
>>>> >> >>> >>> >
>>>> >> >>> >>> > I would like to hear about your opinions about how to add
>>>> >> >>> >>> > new
>>>> >> >>> >>> > xstatic
>>>> >> >>> >>> > modules to horizon settings.
>>>> >> >>> >>> >
>>>> >> >>> >>> > As for Heat-dashboard project embedded 3rd-party files
>>>> >> >>> >>> > issue,
>>>> >> >>> >>> > thanks
>>>> >> >>> >>> > for
>>>> >> >>> >>> > your advices in Dublin PTG, we are now removing them and
>>>> >> >>> >>> > referencing as
>>>> >> >>> >>> > new
>>>> >> >>> >>> > xstatic-* libs.
>>>> >> >>> >>>
>>>> >> >>> >>> Thanks for moving this forward.
>>>> >> >>> >>>
>>>> >> >>> >>> > So we installed the new xstatic files (not uploaded as
>>>> >> >>> >>> > openstack
>>>> >> >>> >>> > official
>>>> >> >>> >>> > repos yet) in our development environment now, but hesitate
>>>> >> >>> >>> > to
>>>> >> >>> >>> > decide
>>>> >> >>> >>> > how to
>>>> >> >>> >>> > add the new installed xstatic lib path to STATICFILES_DIRS
>>>> >> >>> >>> > in
>>>> >> >>> >>> > openstack_dashboard.settings so that the static files could
>>>> >> >>> >>> > be
>>>> >> >>> >>> > automatically
>>>> >> >>> >>> > collected by *collectstatic* process.
>>>> >> >>> >>> >
>>>> >> >>> >>> > Currently Horizon defines BASE_XSTATIC_MODULES in
>>>> >> >>> >>> > openstack_dashboard/utils/settings.py and the relevant
>>>> >> >>> >>> > static
>>>> >> >>> >>> > fils
>>>> >> >>> >>> > are
>>>> >> >>> >>> > added
>>>> >> >>> >>> > to STATICFILES_DIRS before it updates any Horizon plugin
>>>> >> >>> >>> > dashboard.
>>>> >> >>> >>> > We may want new plugin setting keywords ( something similar
>>>> >> >>> >>> > to
>>>> >> >>> >>> > ADD_JS_FILES)
>>>> >> >>> >>> > to update horizon XSTATIC_MODULES (or directly update
>>>> >> >>> >>> > STATICFILES_DIRS).
>>>> >> >>> >>>
>>>> >> >>> >>> IMHO it is better to allow horizon plugins to add xstatic
>>>> >> >>> >>> modules
>>>> >> >>> >>> through horizon plugin settings. I don't think it is a good
>>>> >> >>> >>> idea
>>>> >> >>> >>> to
>>>> >> >>> >>> add a new entry in BASE_XSTATIC_MODULES based on horizon
>>>> >> >>> >>> plugin
>>>> >> >>> >>> usages. It makes difficult to track why and where a xstatic
>>>> >> >>> >>> module
>>>> >> >>> >>> in
>>>> >> >>> >>> BASE_XSTATIC_MODULES is used.
>>>> >> >>> >>> Multiple horizon plugins can add a same entry, so horizon code
>>>> >> >>> >>> to
>>>> >> >>> >>> handle plugin settings should merge multiple entries to a
>>>> >> >>> >>> single
>>>> >> >>> >>> one
>>>> >> >>> >>> hopefully.
>>>> >> >>> >>> My vote is to enhance the horizon plugin settings.
>>>> >> >>> >>>
>>>> >> >>> >>> Akihiro
>>>> >> >>> >>>
>>>> >> >>> >>> >
>>>> >> >>> >>> > Looking forward to hearing any suggestions from you guys,
>>>> >> >>> >>> > and
>>>> >> >>> >>> > Best Regards,
>>>> >> >>> >>> >
>>>> >> >>> >>> > Xinni Ge
>>>> >> >>> >>> >
>>>> >> >>> >>> >
>>>> >> >>> >>> >
>>>> >> >>> >>> >
>>>> >> >>> >>> >
>>>> >> >>> >>> > __________________________________________________________________________
>>>> >> >>> >>> > OpenStack Development Mailing List (not for usage questions)
>>>> >> >>> >>> > Unsubscribe:
>>>> >> >>> >>> >
>>>> >> >>> >>> > OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> >>> >>> >
>>>> >> >>> >>> >
>>>> >> >>> >>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >> >>> >>> >
>>>> >> >>> >>>
>>>> >> >>> >>>
>>>> >> >>> >>>
>>>> >> >>> >>>
>>>> >> >>> >>>
>>>> >> >>> >>> __________________________________________________________________________
>>>> >> >>> >>> OpenStack Development Mailing List (not for usage questions)
>>>> >> >>> >>> Unsubscribe:
>>>> >> >>> >>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> >>> >>>
>>>> >> >>> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >> >>> >>
>>>> >> >>> >>
>>>> >> >>> >>
>>>> >> >>> >>
>>>> >> >>> >> --
>>>> >> >>> >> 葛馨霓 Xinni Ge
>>>> >> >>> >>
>>>> >> >>> >>
>>>> >> >>> >>
>>>> >> >>> >>
>>>> >> >>> >> __________________________________________________________________________
>>>> >> >>> >> OpenStack Development Mailing List (not for usage questions)
>>>> >> >>> >> Unsubscribe:
>>>> >> >>> >> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> >>> >>
>>>> >> >>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >> >>> >>
>>>> >> >>> >
>>>> >> >>> >
>>>> >> >>> >
>>>> >> >>> >
>>>> >> >>> >
>>>> >> >>> > __________________________________________________________________________
>>>> >> >>> > OpenStack Development Mailing List (not for usage questions)
>>>> >> >>> > Unsubscribe:
>>>> >> >>> > OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> >>> >
>>>> >> >>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >> >>> >
>>>> >> >>>
>>>> >> >>>
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> __________________________________________________________________________
>>>> >> >>> OpenStack Development Mailing List (not for usage questions)
>>>> >> >>> Unsubscribe:
>>>> >> >>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >> >>
>>>> >> >>
>>>> >> >>
>>>> >> >>
>>>> >> >>
>>>> >> >> __________________________________________________________________________
>>>> >> >> OpenStack Development Mailing List (not for usage questions)
>>>> >> >> Unsubscribe:
>>>> >> >> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >> >>
>>>> >> >
>>>> >> >
>>>> >> >
>>>> >> > --
>>>> >> > 葛馨霓 Xinni Ge
>>>> >> >
>>>> >> >
>>>> >> >
>>>> >> > __________________________________________________________________________
>>>> >> > OpenStack Development Mailing List (not for usage questions)
>>>> >> > Unsubscribe:
>>>> >> > OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >> >
>>>> >>
>>>> >>
>>>> >> __________________________________________________________________________
>>>> >> OpenStack Development Mailing List (not for usage questions)
>>>> >> Unsubscribe:
>>>> >> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >
>>>> >
>>>> >
>>>> >
>>>> > __________________________________________________________________________
>>>> > OpenStack Development Mailing List (not for usage questions)
>>>> > Unsubscribe:
>>>> > OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>> >
>>>>
>>>>
>>>> __________________________________________________________________________
>>>> OpenStack Development Mailing List (not for usage questions)
>>>> Unsubscribe:
>>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>>
>>>
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>