[openstack-dev] [osc][python-openstackclient] osc-included image signing

Dean Troyer dtroyer at gmail.com
Thu Jun 28 21:18:44 UTC 2018


On Thu, Jun 28, 2018 at 8:04 AM, Josephine Seifert
<josephine.seifert at secustack.com> wrote:
>> Go ahead and post WIP reviews and we can look at it further.  To merge
>> I'll want all of the usual tests, docs, release notes, etc but don't
>> wait if that is not all done up front.
> Here are the two WIP reviews:
>
> cursive: https://review.openstack.org/#/c/578767/
> osc: https://review.openstack.org/#/c/578769/

So one problem I have here is the dependencies of cursive, all of
which become OSC dependencies if cursive is added.  It includes
oslo.log which OSC does not use and doesn't want to use for $REASONS
that boil down to assumptions it makes for server-side use that are
not good for client-side use.

cursive includes castellan which also includes oslo.log and
oslo.context, which I must admit I don't know how it affects a CLI
because we've never tried to include it before.  python-barbicanclient
is also included by cursive, which would make that a new permanent
dependency.  This may be acceptable, it is partially up to the
barbican team if they want to be subject to OSC testing that they may
not have now.

Looking at the changes you have to cursive, if that is all you need
from it those bits could easily go somewhere in osc or osc-lib if you
don't also need them elsewhere.

dt

-- 

Dean Troyer
dtroyer at gmail.com



More information about the OpenStack-dev mailing list