Open Stack

 ---- On Fri, 15 Jun 2018 22:41:41 +0900 Doug Hellmann <doug at doughellmann.com> wrote ---- 
 > Excerpts from Ghanshyam's message of 2018-06-15 09:04:35 +0900:
 > > 
 > > 
 > > 
 > >  ---- On Fri, 15 Jun 2018 06:17:34 +0900 Doug Hellmann <doug at doughellmann.com> wrote ---- 
 > >  > Excerpts from Doug Hellmann's message of 2018-06-14 13:02:31 -0400:
 > >  > > Excerpts from Ghanshyam's message of 2018-06-14 16:54:33 +0900:
 > >  > 
 > >  > > >  > > > Could it be as simple as adding tempest-full-py3 with the
 > >  > > >  > > > required-projects list updated to include the current repository? So
 > >  > > >  > > > there isn't a special separate job, and we would just reuse
 > >  > > >  > > > tempest-full-py3 for this?
 > >  > > > 
 > >  > > > This can work if lib-forward-testing is going to run against current lib repo only not cross lib or cross project. For example, if neutron want to tests neutron change against neutron-lib src  then this will not work. But from history [1] this does not seems to be scope of lib-forward-testing.
 > >  > > > 
 > >  > > > Even  we do not need to add current repo to required-projects list or in LIBS_FROM_GIT .  That will always from master + current patch changes. So this makes no change in tempest-full-py3 job and we can directly use  tempest-full-py3 job in lib-forward-testing. Testing in [2].
 > >  > > 
 > >  > > Does it? So if I add tempest-full-py3 to a *library* that library is
 > >  > > installed from source in the job? I know the source for the library
 > >  > > will be checked out, but I'm surprised that devstack would be configured
 > >  > > to use it. How does that work?
 > >  > 
 > >  > Based on my testing, that doesn't seem to be the case. I added it to
 > >  > oslo.config and looking at the logs [1] I do not set LIBS_FROM_GIT set
 > >  > to include oslo.config and the check function is returning false so that
 > >  > it is not installed from source [2].
 > > 
 > > Yes, It will not be set on LIBS_FROM_GIT as we did not set it explicitly. But gate running on any repo does run job on current change set of that repo which is nothing but  "master + current patch changes" . For example, any job running on oslo.config patch will take oslo.config source code from that patch which is "master + current change". You can see the results in this patch - https://review.openstack.org/#/c/575324/ . Where I deleted a module and gate jobs (including tempest-full-py3) fails as they run on current change set of neutron-lib code not on pypi version(which would pass the tests). 
 > 
 > The tempest-full-py3 job passed for that patch, though. Which seems to
 > indicate that the neutron-lib repository was not used in the test job,
 > even though it was checked out.

oops, I saw the other job failure and overlooked tempest-full-py3 (friday night effect :)). Your point is correct on LIBS_FROM_GIT . 


-gmann

 > 
 > > 
 > > In that case, lib's proposed change will be tested against integration tests  job to check any regression. If we need to run cross lib/project testing of any lib then, yes we need the 'tempest-full-py3-src' job but that is separate things as you mentioned. 
 > > 
 > > -gmann
 > > 
 > >  > 
 > >  > So, I think we need the tempest-full-py3-src job. I will propose an
 > >  > update to the tempest repo to add that.
 > >  > 
 > >  > Doug
 > >  > 
 > >  > [1] http://logs.openstack.org/64/575164/2/check/tempest-full-py3/9aa50ad/job-output.txt.gz
 > >  > [2] http://logs.openstack.org/64/575164/2/check/tempest-full-py3/9aa50ad/job-output.txt.gz#_2018-06-14_19_40_56_223136
 > >  > 
 > >  > __________________________________________________________________________
 > >  > OpenStack Development Mailing List (not for usage questions)
 > >  > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
 > >  > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 > >  > 
 > > 
 > 
 > __________________________________________________________________________
 > OpenStack Development Mailing List (not for usage questions)
 > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
 > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 >