[openstack-dev] [oslo][oslo.log]Re: Error will be occurred if watch_log_file option is true

Rikimaru Honjo honjo.rikimaru at po.ntt-tx.co.jp
Wed Jan 31 11:03:46 UTC 2018


Sorry for the very late reply...

On 2018/01/10 1:11, Doug Hellmann wrote:
> Excerpts from Rikimaru Honjo's message of 2018-01-09 18:11:09 +0900:
>> Hello,
>> On 2018/01/04 23:12, Doug Hellmann wrote:
>>> Excerpts from Rikimaru Honjo's message of 2018-01-04 18:22:26 +0900:
>>>> Hello,
>>>> The below bug was reported in Masakari's Launchpad.
>>>> I think that this bug was caused by oslo.log.
>>>> (And, the root cause is a bug of pyinotify using by oslo.log. The detail is
>>>> written in the bug report.)
>>>> * masakari-api failed to launch due to setting of watch_log_file and log_file
>>>>      https://bugs.launchpad.net/masakari/+bug/1740111
>>>> There is a possibility that this bug will affects all openstack components using oslo.log.
>>>> (But, the processes working with uwsgi[1] wasn't affected when I tried to reproduce.
>>>> I haven't solved the reason of this yet...)
>>>> Could you help us?
>>>> And, what should we do...?
>>>> [1]
>>>> e.g. nova-api, cinder-api, keystone...
>>>> Best regards,
>>> The bug is in pyinotify. According to the git repo [1] that project
>>> was last updated in June of 2015.  I recommend we move off of
>>> pyinotify entirely, since it appears to be unmaintained.
>>> If there is another library to do the same thing we should switch
>>> to it (there seem to be lots of options [2]). If there is no viable
>>> replacement or fork, we should deprecate that log watching feature
>>> (and anything else for which we use pyinotify) and remove it ASAP.
>>> We'll need a volunteer to do the evaluation and update oslo.log.
>>> Doug
>>> [1] https://github.com/seb-m/pyinotify
>>> [2] https://pypi.python.org/pypi?%3Aaction=search&term=inotify&submit=search
>> Thank you for replying.
>> I haven't deeply researched, but inotify looks good.
>> Because "weight" of inotify is the largest, and following text is described.
>> https://pypi.python.org/pypi/inotify/0.2.9
>>> This project is unrelated to the *PyInotify* project that existed prior to this one (this project began in 2015). That project is defunct and no longer available.
>> PyInotify is defunct and no longer available...
> The inotify package seems like a good candidate to replace pyinotify.
> Have you looked at how hard it would be to change oslo.log? If so, does
> using the newer library eliminate the bug you had?
I am researching it now. (But, I think it is not easy.)
I'll create a patch if inotify can eliminate the bug.

> Doug
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Rikimaru Honjo
E-mail:honjo.rikimaru at po.ntt-tx.co.jp

More information about the OpenStack-dev mailing list