[openstack-dev] [os-vif]

Sriharsha Basavapatna sriharsha.basavapatna at broadcom.com
Tue Jan 9 08:50:35 UTC 2018

Hi Andreas,

On Tue, Jan 9, 2018 at 12:04 PM, Andreas Jaeger <aj at suse.com> wrote:
> On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
>> Hi,
>> I've uploaded a patch for review:
>> https://review.openstack.org/#/c/531674/
>> This is the first time I'm submitting a patch on openstack. I'd like
> Welcome to OpenStack, Harsha.

Thank you.

> Please read
> https://docs.openstack.org/infra/manual/developers.html if you haven't.

Ok, i'll read it.
> I see that your change fails the basic tests, you can run these locally
> as follows to check that your fixes will pass:
> tox -e pep8
> tox -e py27

I was wondering if there's a way to catch these errors without having
to submit it for gerrit review.  I fixed the ones that were reported
in patch-set-1; looks like there's some new ones in the second
patch-set. I'll run the above commands to verify the fix locally.


> Andreas
>> to add code reviewers on this patch. I'd appreciate if you could point
>> me to any guidelines on how to pick reviewers for a given project
>> (os-vif library in this case).
>> Thanks,
>> -Harsha
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>    GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>        HRB 21284 (AG Nürnberg)
>     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

More information about the OpenStack-dev mailing list