Open Stack

On 06/08/18 13:11, Thomas Goirand wrote:
> On 08/02/2018 10:43 AM, Andrey Kurilin wrote:
>>      There's also some "raise StopIteration" issues in:
>>      - ceilometer
>>      - cinder
>>      - designate
>>      - glance
>>      - glare
>>      - heat
>>      - karbor
>>      - manila
>>      - murano
>>      - networking-ovn
>>      - neutron-vpnaas
>>      - nova
>>      - rally
>>
>>
>> Can you provide any traceback or steps to reproduce the issue for Rally
>> project ?

I assume Thomas is only trying to run the unit tests, since that's what 
he has to do to verify the package?

> I'm not sure there's any. The only thing I know is that it has stop
> StopIteration stuff, but I'm not sure if they are part of generators, in
> which case they should simply be replaced by "return" if you want it to
> be py 3.7 compatible.

I was about to say nobody is doing 'raise StopIteration' where they mean 
'return' until I saw that the Glance tests apparently were :D

The main issue though is when StopIteration is raised by one thing that 
happens to be called from *another* generator. e.g. many of the Heat 
tests that are failing are because we supplied a too-short list of 
side-effects to a mock and calling next() on them raises StopIteration, 
but because the calls were happening from inside a generator the 
StopIterations previously just got swallowed. If no generator were 
involved the test would have failed with the StopIteration exception. 
(Note: this was a bug - either in the code or more likely the tests. The 
purpose of the change in py37 was to expose this kind of bug wherever it 
exists.)

> I didn't have time to investigate these, but at least Glance was
> affected, and a patch was sent (as well as an async patch). None of them
> has been merged yet:
> 
> https://review.openstack.org/#/c/586050/
> https://review.openstack.org/#/c/586716/
> 
> That'd be ok if at least there was some reviews. It looks like nobody
> cares but Debian & Ubuntu people... :(
> 
> Cheers,
> 
> Thomas Goirand (zigo)
> 
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>