Open Stack

Hi Hamdy,
Thanks for quick action.

Regards
Maciej

From: Hamdy Khader [mailto:hamdyk at mellanox.com]
Sent: Tuesday, April 17, 2018 12:51 PM
To: OpenStack-dev at lists.openstack.org
Subject: Re: [openstack-dev] [Os-brick][Cinder] NVMe-oF NQN string


Hi,

I think you're right, will drop the split and push change soon.



Regards,

Hamdy

________________________________
From: Szwed, Maciej <maciej.szwed at intel.com<mailto:maciej.szwed at intel.com>>
Sent: Monday, April 16, 2018 4:51 PM
To: OpenStack-dev at lists.openstack.org<mailto:OpenStack-dev at lists.openstack.org>
Subject: [openstack-dev] [Os-brick][Cinder] NVMe-oF NQN string


Hi,

I'm wondering why in Os-brick implementation of NVMe-oF in os_brick/initiator/connectors/nvme.py, line 97 we do split on 'nqn'. Connection properties, including 'nqn', are provided by Cinder driver and when user want to implement new driver that will use NVMe-of he/she needs to create NQN string with additional string and dot proceeding the desired NQN string. This additional string is unused across whole NVMe-oF implementation. This creates confusion for people when creating new Cinder driver. What was its purpose? Can we drop that split?



Regards,

Maciej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180419/309909ab/attachment-0001.html>