[openstack-dev] Garbage patches for simple typo fixes

Tom Barron tpb at dyncloud.net
Sat Sep 23 02:27:06 UTC 2017



On 09/22/2017 08:34 PM, Zhipeng Huang wrote:
> Hi Paul,
> 
> Unfortunately I know better on this matter and it is not the matter of
> topic dispute as many people on this thread who has been disturbed and
> annoyed by the padding/trolling.
> 
> So yes I'm sticking with stupid because it hurts the OpenStack community
> as a whole and hurts the reputation of the dev community from my country
> which in large are great people with good hearts and skills.
> 
> I'm not giving even an inch of the benefit of doubt to these padding
> activities and people behind it.
> 

I don't want to be naive here: humans tend to stereotype and generalize
in just the way you are talking about.  Some say it's the inherited
"fight or flight" part of our brains that uses heuristics based on
survival from when we lived in packs and tribes that causes us to
over-ride the systematic, analytic reasoning parts which when we use
them shows the statistical invalidity of "reasoning" from a few bad
actors to larger populations.

But I do hope that we in the OpenStack community are building not just
software but a way of doing things so that generalizations about nations
and peoples do not get made because of unhelpful behavior on the part of
a few, however active or prominent they may be.  A big part of why I
like working in this community is that we are learning together not just
how to build better software but also how to work in common purpose
across timezones and cultures based on a willingness to assume good will
as a starting point, to share information, and treat one another fairly.

So I'm still for (1) some published boilerplate that reviewers can point
to without blaming anyone or speculatively attributing motive, and (2)
outreach of the sort that Doug Hellman advocated in cases where #1
doesn't seem sufficient.  Part of that outreach might involve getting an
understanding of what the parties involved *think* is being gained by
unhelpful patches, making sure that OpenStack does not reward or
re-enforce this behavior (like blindly looking at Stackalytics, if that
does indeed happen), and effectively communicating how the unhelpful
behavior does not pay off in our community.

> 
> On Sat, Sep 23, 2017 at 8:16 AM, Paul Belanger <pabelanger at redhat.com
> <mailto:pabelanger at redhat.com>> wrote:
> 
>     On Fri, Sep 22, 2017 at 10:26:09AM +0800, Zhipeng Huang wrote:
>     > Let's not forget the epic fail earlier on the "contribution.rst fix" that
>     > almost melt down the community CI system.
>     >
>     > For any companies that are doing what Matt mentioned, please be aware that
>     > the dev community of the country you belong to is getting hurt by your
>     > stupid activity.
>     >
>     > Stop patch trolling and doing something meaningful.
>     >
>     Sorry, but I found this comment over the line. Just because you
>     disagree with
>     the $topic at hand, doesn't mean you should default to calling it
>     'stupid'. Give
>     somebody the benefit of not knowing any better.
> 
>     This is not a good example of encouraging anybody to contribute to
>     the project.
> 
>     -Paul
> 
>     > On Fri, Sep 22, 2017 at 10:21 AM, Matt Riedemann
>     <mriedemos at gmail.com <mailto:mriedemos at gmail.com>>
>     > wrote:
>     >
>     > > I just wanted to highlight to people that there seems to be a
>     series of
>     > > garbage patches in various projects [1] which are basically
>     doing things
>     > > like fixing a single typo in a code comment, or very narrowly
>     changing http
>     > > to https in links within docs.
>     > >
>     > > Also +1ing ones own changes.
>     > >
>     > > I've been trying to snuff these out in nova, but I see it's
>     basically a
>     > > pattern widespread across several projects.
>     > >
>     > > This is the boilerplate comment I give with my -1, feel free to
>     employ it
>     > > yourself.
>     > >
>     > > "Sorry but this isn't really a useful change. Fixing typos in code
>     > > comments when the context is still clear doesn't really help us,
>     and mostly
>     > > seems like looking for padding stats on stackalytics. It's also
>     a drain on
>     > > our CI environment.
>     > >
>     > > If you fixed all of the typos in a single module, or in user-facing
>     > > documentation, or error messages, or something in the logs, or
>     something
>     > > that actually doesn't make sense in code comments, then maybe,
>     but this
>     > > isn't one of those things."
>     > >
>     > > I'm not trying to be a jerk here, but this is annoying to the
>     point I felt
>     > > the need to say something publicly.
>     > >
>     > > [1] https://review.openstack.org/#/q/author:%255E.*inspur.*
>     <https://review.openstack.org/#/q/author:%255E.*inspur.*>
>     > >
>     > > --
>     > >
>     > > Thanks,
>     > >
>     > > Matt
>     > >
>     > >
>     __________________________________________________________________________
>     > > OpenStack Development Mailing List (not for usage questions)
>     > > Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     > >
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>     > >
>     >
>     >
>     >
>     > --
>     > Zhipeng (Howard) Huang
>     >
>     > Standard Engineer
>     > IT Standard & Patent/IT Product Line
>     > Huawei Technologies Co,. Ltd
>     > Email: huangzhipeng at huawei.com <mailto:huangzhipeng at huawei.com>
>     > Office: Huawei Industrial Base, Longgang, Shenzhen
>     >
>     > (Previous)
>     > Research Assistant
>     > Mobile Ad-Hoc Network Lab, Calit2
>     > University of California, Irvine
>     > Email: zhipengh at uci.edu <mailto:zhipengh at uci.edu>
>     > Office: Calit2 Building Room 2402
>     >
>     > OpenStack, OPNFV, OpenDaylight, OpenCompute Aficionado
> 
>     >
>     __________________________________________________________________________
>     > OpenStack Development Mailing List (not for usage questions)
>     > Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
> 
> 
>     __________________________________________________________________________
>     OpenStack Development Mailing List (not for usage questions)
>     Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
> 
> 
> 
> 
> -- 
> Zhipeng (Howard) Huang
> 
> Standard Engineer
> IT Standard & Patent/IT Product Line
> Huawei Technologies Co,. Ltd
> Email: huangzhipeng at huawei.com <mailto:huangzhipeng at huawei.com>
> Office: Huawei Industrial Base, Longgang, Shenzhen
> 
> (Previous)
> Research Assistant
> Mobile Ad-Hoc Network Lab, Calit2
> University of California, Irvine
> Email: zhipengh at uci.edu <mailto:zhipengh at uci.edu>
> Office: Calit2 Building Room 2402
> 
> OpenStack, OPNFV, OpenDaylight, OpenCompute Aficionado
> 
> 
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 



More information about the OpenStack-dev mailing list