Open Stack

On 2017-09-20 14:37:27 -0400 (-0400), Doug Hellmann wrote:
> Excerpts from Jeremy Stanley's message of 2017-09-20 18:35:23 +0000:
> > On 2017-09-20 14:24:32 -0400 (-0400), Doug Hellmann wrote:
> > [...]
> > > it doesn't really solve the problem of having to update the
> > > branches every time we open one. Having tox_install.sh figure out
> > > the URL from the .gitreview file addresses that, but it may be too
> > > magic for some folks. I don't know if we have generally agreed to
> > > let anything other than git-review look at that file.
> > 
> > Further, git-review has grown additional magic to allow it to figure
> > out sane values for defaultbranch when omitted from the .gitreview
> > file, so having other tools depend on that implementation detail
> > could come back to bite us down the road.
> 
> It sounds like we want git-review to have a mode that prints the
> branch to which the change would be proposed, without actually
> proposing anything. Our scripts could then use that.

"Our scripts" maybe... but calling it from tox.ini to guess branches
adds an implicit dependency on git-review for every project doing
that, at least for developers who want to be able to make use of the
constraints URL fallback.
-- 
Jeremy Stanley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170920/28656d3f/attachment.sig>