Open Stack

On Thu, Oct 19, 2017 at 4:56 PM James Slagle <james.slagle at gmail.com> wrote:

> I've been looking at how we can hook up the deployment changes for
> config-download[1] with the existing deployment workflows in Mistral.
>
> However, it seems we have not sufficiently abstracted the logic to do
> a "deployment" behind a given workflow(s). The existing things a
> client (or UI) has to do is:
>
> - call tripleo.deployment.v1.deploy_plan
> - poll for success/failure of that workflow
> - poll for success/failure of in progress Heat stack (list events, etc)
> - call tripleo.deployment.v1.overcloudrc
> (probably more things too)
>
> If I want to make some changes to the deployment workflow, such that
> after the Heat stack operation is complete, we run a config-download
> action/workflow, then apply the generated ansible via
> ansible-playbook, I can't really do that without requiring all clients
> to also get updated to use those new steps (via calling new workflows,
> etc).
>
> As a first attempt, I took a shot at creating a workflow that does every
> step:
> https://review.openstack.org/#/c/512876/
> But even that will require client changes as it necessitates a
> behavior change in that the workflow has to wait for the stack to be
> complete as opposed to returning as soon as the stack operation is
> accepted by Heat.
>
>
Thankfully we already have that capability. :)


> I'd like to implement this in a way that minimizes the impact of
> changes on both python-tripleoclient and tripleo-ui, but it's looking
> as if some changes would be required to use this new ansible driven
> approach.
>
> Thoughts or feedback on how to proceed? I'm guess I'm also wondering
> if the existing API exposed by the workflows is easy to consume by the
> UI, or if it would be better to be wrapped in a single workflow...at
> least that way we could make logical implementation changes without
> requiring ui/cilent changes.
>
> [1] https://blueprints.launchpad.net/tripleo/+spec/ansible-config-download
>
>
+1 to all of this. I think from the CLI perspective, it should be a minimal
impact. If anything, it will get rid of a lot of code that doesn't really
belong. I can't say what the impact to the UI would be. However, one thing
that we should make sure of is that we send messages back through Zaqar to
keep the CLI and UI informed of what is occurring. That should happen
already with most of the existing workflows.

This is a great step in the right direction. The Workflows squad will be
happy to assist in any way we can. We will start by reviewing what you have
so far.


> --
> -- James Slagle
> --
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-- 
Brad P. Crochet, RHCA, RHCE, RHCVA, RHCDS
Principal Software Engineer
(c) 704.236.9385
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20171020/fefb5a2b/attachment.html>