[openstack-dev] [neutron] [infra] Depends-on tag effect

Hirofumi Ichihara ichihara.hirofumi at lab.ntt.co.jp
Thu Mar 9 13:59:39 UTC 2017



On 2017/03/09 2:33, Armando M. wrote:
>
>
> On 8 March 2017 at 07:39, Hirofumi Ichihara 
> <ichihara.hirofumi at lab.ntt.co.jp 
> <mailto:ichihara.hirofumi at lab.ntt.co.jp>> wrote:
>
>
>
>     On 2017/03/08 23:59, Andreas Jaeger wrote:
>
>         On 2017-03-08 15:40, ZZelle wrote:
>
>             Hi,
>
>             iiuc, neutron uses a released version of neutron-lib not
>             neutron-lib
>             master ... So the change should depends on a change in
>             requirements repo
>             incrementing neutron-lib version
>
>         This is documented also at - together with some other caveats:
>
>         https://docs.openstack.org/infra/manual/developers.html#limitations-and-caveats
>         <https://docs.openstack.org/infra/manual/developers.html#limitations-and-caveats>
>
>     Thank you for the pointer. I understand.
>
>
> You can do the reverse as documented in [1]: i.e. file a dummy patch 
> against neutron-lib that pulls in both neutron's and neutron-lib 
> changes. One example is [2]
>
> [1] 
> https://docs.openstack.org/developer/neutron-lib/review-guidelines.html
> [2] https://review.openstack.org/#/c/386846/
That makes sense. I missed the documentation. Thank you for your help.

>
>
>     Hirofumi
>
>
>
>
>         Note a depends-on requirements won't work either - you really
>         need to
>         release it. Or you need to change the test to pull neutron-lib
>         from source,
>
>         Andreas
>
>             On Wed, Mar 8, 2017 at 3:16 PM, Hirofumi Ichihara
>             <ichihara.hirofumi at lab.ntt.co.jp
>             <mailto:ichihara.hirofumi at lab.ntt.co.jp>
>             <mailto:ichihara.hirofumi at lab.ntt.co.jp
>             <mailto:ichihara.hirofumi at lab.ntt.co.jp>>> wrote:
>
>                  Hi,
>
>                  I thought that we can post neutron patch depending on
>             neutron-lib
>                  patch under review.
>                  However, I saw it doesn't work[1, 2]. In the patches,
>             neutron
>                  patch[1] has Depends-on tag with neutron-lib patch[2]
>             but the pep8
>                  and unit test fails because the test doesn't use the
>             neutron-lib patch.
>
>                  Please correct me if it's my misunderstanding.
>
>                  [1]: https://review.openstack.org/#/c/424340/
>             <https://review.openstack.org/#/c/424340/>
>                  <https://review.openstack.org/#/c/424340/
>             <https://review.openstack.org/#/c/424340/>>
>                  [2]: https://review.openstack.org/#/c/424868/
>             <https://review.openstack.org/#/c/424868/>
>                  <https://review.openstack.org/#/c/424868/
>             <https://review.openstack.org/#/c/424868/>>
>
>                  Thanks,
>                  Hirofumi
>
>
>
>                
>              __________________________________________________________________________
>                  OpenStack Development Mailing List (not for usage
>             questions)
>                  Unsubscribe:
>             OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>             <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>                
>              <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe
>             <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>>
>             http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>             <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>                
>              <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>             <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>>
>
>
>
>
>             __________________________________________________________________________
>             OpenStack Development Mailing List (not for usage questions)
>             Unsubscribe:
>             OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>             <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>             http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>             <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>
>
>
>
>
>
>     __________________________________________________________________________
>     OpenStack Development Mailing List (not for usage questions)
>     Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170309/4bbc31d3/attachment.html>


More information about the OpenStack-dev mailing list