Open Stack

On Mon, Mar 6, 2017 at 3:09 AM, Zhenyu Zheng 
<zhengzhenyulixi at gmail.com> wrote:
> Hi, Matt
> 
> AFAIK, searchlight did delete the record, it catch the 
> instance.delete notification and perform the action:
> http://git.openstack.org/cgit/openstack/searchlight/tree/searchlight/elasticsearch/plugins/nova/notification_handler.py#n100
> -> 
> http://git.openstack.org/cgit/openstack/searchlight/tree/searchlight/elasticsearch/plugins/nova/notification_handler.py#n307

Hi,

There is instance.soft_delete legacy notification [2] (delete_type == 
'soft_delete'). This could be transformed to versioned notification 
along with [3]. So I guess there could be a way to distinguish between 
soft delete and real delete on searchlight side based on these 
notifications.

Cheers,
gibi

[2] 
https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1872
[3] https://review.openstack.org/#/c/410297/


> I will double check with others from the SL team, and if it is the 
> case, we will try to find a way to solve this ASAP.
> 
> Thanks,
> 
> Kevin Zheng
> 
> On Mon, Mar 6, 2017 at 1:21 AM, Matt Riedemann <mriedemos at gmail.com> 
> wrote:
>> I've posted a spec [1] for nova's integration with searchlight for 
>> listing instance across multiple cells. One of the open questions I 
>> have on that is when/how do instances get removed from searchlight?
>> 
>> When an instance gets deleted via the compute API today, it's not 
>> really deleted from the database. It's considered "soft" deleted and 
>> you can still list (soft) deleted instances from the database via 
>> the compute API if you're an admin.
>> 
>> Nova will be sending instance.destroy notifications to searchlight 
>> but we don't really want the ES entry removed because we still have 
>> to support the compute API contract to list deleted instances. 
>> Granted, this is a pretty limp contract because there is no 
>> guarantee that you'll be able to list those deleted instances 
>> forever because once they get archived (moved to shadow tables in 
>> the nova database) or purged (hard delete), then they are gone from 
>> that API query path.
>> 
>> So I'm wondering at what point instances stored in searchlight will 
>> be removed. Maybe there is already an answer to this and the 
>> searchlight team can just inform me. Otherwise we might need to 
>> think about data retention policies and how long a deleted instances 
>> will be stored in searchlight before it's removed. Again, I'm not 
>> sure if nova would control this or if it's something searchlight 
>> supports already.
>> 
>> [1] https://review.openstack.org/#/c/441692/
>> 
>> --
>> 
>> Thanks,
>> 
>> Matt Riedemann
>> 
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: 
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>