[openstack-dev] [neutron] pep8 broken

Gary Kotton gkotton at vmware.com
Wed Jun 7 11:05:11 UTC 2017


Hi,
More details:

The urllib<https://docs.python.org/2/library/urllib.html#module-urllib>, urllib2<https://docs.python.org/2/library/urllib2.html#module-urllib2>, and urlparse<https://docs.python.org/2/library/urlparse.html#module-urlparse> modules have been combined in the urllib<https://docs.python.org/3/library/urllib.html#module-urllib> package in Python 3. The six.moves.urllib package is a version-independent location for this functionality; its structure mimics the structure of the Python 3 urllib<https://docs.python.org/3/library/urllib.html#module-urllib> package.

Thanks and sorry for the spam
Gary

From: Gary Kotton <gkotton at vmware.com>
Date: Wednesday, June 7, 2017 at 2:03 PM
To: OpenStack List <openstack-dev at lists.openstack.org>
Subject: Re: [openstack-dev] [neutron] pep8 broken

Sorry my bad.
The problem is that our requirements use six and in 1.10 files are missing


From: Gary Kotton <gkotton at vmware.com>
Reply-To: OpenStack List <openstack-dev at lists.openstack.org>
Date: Wednesday, June 7, 2017 at 1:00 PM
To: OpenStack List <openstack-dev at lists.openstack.org>
Subject: Re: [openstack-dev] [neutron] pep8 broken

Seems like the whole world is broken now:

2017-06-07 09:56:23.336255<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_56_23_336255> | pep8 runtests: PYTHONHASHSEED='681905263'
2017-06-07 09:56:23.336291<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_56_23_336291> | pep8 runtests: commands[0] | sh ./tools/misc-sanity-checks.sh
2017-06-07 09:56:23.338319<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_56_23_338319> |   /home/jenkins/workspace/gate-vmware-nsx-pep8-ubuntu-xenial$ /bin/sh ./tools/misc-sanity-checks.sh
2017-06-07 09:56:26.180998<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_56_26_180998> | pep8 runtests: commands[1] | flake8
2017-06-07 09:56:26.183583<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_56_26_183583> |   /home/jenkins/workspace/gate-vmware-nsx-pep8-ubuntu-xenial$ /home/jenkins/workspace/gate-vmware-nsx-pep8-ubuntu-xenial/.tox/pep8/bin/flake8
2017-06-07 09:57:02.335638<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_02_335638> | pep8 runtests: commands[2] | sh ./tools/coding-checks.sh --pylint
2017-06-07 09:57:02.338619<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_02_338619> |   /home/jenkins/workspace/gate-vmware-nsx-pep8-ubuntu-xenial$ /bin/sh ./tools/coding-checks.sh --pylint
2017-06-07 09:57:02.339139<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_02_339139> | Running pylint...
2017-06-07 09:57:02.339210<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_02_339210> | You can speed this up by running it on 'HEAD~[0-9]' (e.g. HEAD~1, this change only)...
2017-06-07 09:57:02.966716<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_02_966716> | Problem importing module classes.pyc: cannot import name InferenceContext
2017-06-07 09:57:02.982457<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_02_982457> | Problem importing module classes.py: cannot import name InferenceContext
2017-06-07 09:57:03.398914<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_398914> | [7;33m************* Module vmware_nsx.nsx_cluster[0m
2017-06-07 09:57:03.399073<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399073> | [1;31mE[0m: 45, 8: [1;31mUndefined variable 'self'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399152<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399152> | [1;31mE[0m: 46, 8: [1;31mUndefined variable 'self'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399222<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399222> | [1;31mE[0m: 47, 8: [1;31mUndefined variable 'self'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399267<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399267> | [1;31mE[0m: 48, 8: [1;31mUndefined variable 'self'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399308<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399308> | [1;31mE[0m: 48,27: [1;31mUndefined variable 'kwargs'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399348<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399348> | [1;31mE[0m: 50,38: [1;31mUndefined variable 'self'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399385<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399385> | [1;31mE[0m: 53,46: [1;31mUndefined variable 'opt'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399424<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399424> | [1;31mE[0m: 54,32: [1;31mUndefined variable 'self'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399482<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399482> | [1;31mE[0m: 54,54: [1;31mUndefined variable 'opt'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399547<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399547> | [1;31mE[0m: 55,15: [1;31mUndefined variable 'depr_func'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399617<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399617> | [1;31mE[0m: 56,16: [1;31mUndefined variable 'depr_func'[0m ([1;31mundefined-variable[0m)
2017-06-07 09:57:03.399683<http://logs.openstack.org/66/471666/2/check/gate-vmware-nsx-pep8-ubuntu-xenial/b1bc4df/console.html#_2017-06-07_09_57_03_399683> | [1;31mE[0m: 56,26: [1;31mUndefined variable 'val'[0m ([1;31mundefined-variable[0m)



From: Gary Kotton <gkotton at vmware.com>
Date: Wednesday, June 7, 2017 at 12:05 PM
To: OpenStack List <openstack-dev at lists.openstack.org>
Subject: Re: [openstack-dev] [neutron] pep8 broken

Thanks!

Maybe this is the source of the failures that we are seeing now and we need to address that in the decomposed projects.

From: Kevin Benton <kevin at benton.pub>
Reply-To: OpenStack List <openstack-dev at lists.openstack.org>
Date: Wednesday, June 7, 2017 at 11:59 AM
To: OpenStack List <openstack-dev at lists.openstack.org>
Subject: Re: [openstack-dev] [neutron] pep8 broken

I think this was meant to fix it. https://review.openstack.org/#/c/471512/

On Wed, Jun 7, 2017 at 4:51 AM, Gary Kotton <gkotton at vmware.com<mailto:gkotton at vmware.com>> wrote:
Hi,
It seems that the pep8 is broken due to https://github.com/openstack/requirements/commit/99fae827973465147359cc7032c83003802612a7<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openstack_requirements_commit_99fae827973465147359cc7032c83003802612a7&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=PMrZQUSXojEgJQPh7cZrz1Lvja0OwAstg0U82FalZrw&m=-4ErU2yIKEhsHlidjK8bsYqNHbBNes1m53GBtaagckE&s=03DfTv37JtfBJjCw02wzp8Up2hucSiIJLxGSWawTZJI&e=>
Should we revert this?
Thanks
Gary

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170607/4ccb6844/attachment.html>


More information about the OpenStack-dev mailing list