[openstack-dev] [keystone] deprecating and removing tools/sample_data.sh

Lance Bragstad lbragstad at gmail.com
Tue Jul 11 19:19:19 UTC 2017


Good point. I did a bit more digging and it looks like it was originally
intended for devstack [0]. At least based on the original commit message
that introduced the file. Devstack seems to take its own approach to
generating sample data, mainly using keystone-manage and functions
defined in lib/keystone [1].

I'll propose a patch to remove it and we can continue the discussion in
Gerrit.

Thanks!


[0]
https://github.com/openstack/keystone/commit/09a64dd862463fe116c4ddb8aee538e4bc7f56e0
[1]
https://github.com/openstack-dev/devstack/blob/e4b2e3b93e892df3cb4be778bcd9813cf17f9a1c/lib/keystone#L331


On 07/05/2017 04:28 PM, Colleen Murphy wrote:
> On Wed, Jul 5, 2017 at 9:36 PM, Lance Bragstad <lbragstad at gmail.com
> <mailto:lbragstad at gmail.com>> wrote:
>
>     Hi all,
>
>     Keystone has a script to perform some bootstrapping operations
>     [0]. It's
>     not really tested and its purpose has been superseded by using the
>     `keystone-manage bootstrap` command. Based on codesearch, only
>     openstack/rpm-packaging references the script [1].
>
> It's not exactly superceded by `keystone-manage bootstrap` - in fact
> it uses bootstrap as part of its data generation:
>
> https://github.com/openstack/keystone/blob/82f60fe22c405829f8e5f6576f25cf3663b10f73/tools/sample_data.sh#L97
>
>
>
>     Is anyone opposed to the removal of this script in favor of more
>     supported and tested bootstrapping methods?
>
> I haven't used this script in a while but I have found value in it in
> the past. It would be great if it or something like it was gate tested.
>
> Colleen 
>
>
>     Thanks,
>
>
>     [0]
>     https://github.com/openstack/keystone/blob/82f60fe22c405829f8e5f6576f25cf3663b10f73/tools/sample_data.sh
>     <https://github.com/openstack/keystone/blob/82f60fe22c405829f8e5f6576f25cf3663b10f73/tools/sample_data.sh>
>     [1]
>     http://codesearch.openstack.org/?q=sample_data.sh&i=nope&files=&repos=
>     <http://codesearch.openstack.org/?q=sample_data.sh&i=nope&files=&repos=>
>
>
>
>     __________________________________________________________________________
>     OpenStack Development Mailing List (not for usage questions)
>     Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170711/b3559a29/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170711/b3559a29/attachment.sig>


More information about the OpenStack-dev mailing list