Open Stack

Thanks Andrea!

For the first I will do as advised.  I will just add the prefix before the name then append the path afterwards.

For the second test with end_marker I will just make that upper case (‘ZzzzObject1234567890’) a lower case (‘zzzzObject1234567890’) I believe this was the intended behavior and ‘Z’ was a typo since when adding the beginning marker earlier in the code a capital ‘A’ ('AaaaObject1234567890') was correctly used because ‘A’ is the lowest letter but ‘z’ is the highest letter and should start for end marker.

Josh


From: Andrea Frittoli [mailto:andrea.frittoli at gmail.com]
Sent: Monday, January 30, 2017 10:42 AM
To: OpenStack Development Mailing List (not for usage questions) <openstack-dev at lists.openstack.org>; ghanshyammann at gmail.com; zhu.bingbing at 99cloud.net; Daryl Walleck <daryl.walleck at rackspace.com>
Subject: Re: [openstack-dev] [QA] Gate Jobs failing after patch for bug/1628016


On Mon, Jan 30, 2017 at 3:25 PM White, Joshua L <joshua.l.white at intel.com<mailto:joshua.l.white at intel.com>> wrote:

Hi Team,



I would like to get your feedback on the gate jobs failing and how to alleviate the issue.

The gate jobs are failing once the prefix is actually added for these tests jobs below:

1. test_list_container_contents_with_path

Issue:
    For some reason whoever coded this test hardcoded the file path and name ("Swift/TestObject").
    Which means when the prefix is added instead of '<prefix>-TestObject' its '<prefix>-Swift/TestObject' resulting in the failure because the path is wrong.


Objects with slashes in their name are used to setup paths.
You could change the test so that it uses rand_name for the part after the path only, e.g. Swift/<random>-TestObject, or you could change the params to match the random path.


2. test_list_container_contents_with_end_marker

Issue:
    This test will only pass if the prefix begins with a capital letter.  '<Prefix>' works but '<prefix>' fails

This is because the marker starts with "Z" which comes before any low case letter in ascii order. You could change the end marker, or even better you could build the end marker dynamically based on the prefix to make sure it comes after the object name.

andrea

I am trying to find the correct way to fix these issues without doing something that’s just hacky.

Please see patch for reference: https://review.openstack.org/#/c/397504/

Thanks,

Joshua White
irc: jlwhite


__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170130/76bd0bfd/attachment.html>