[openstack-dev] [Neutron][Oslo] Huge number of deprecation warnings in functional tests

Davanum Srinivas davanum at gmail.com
Sun Jan 29 15:39:45 UTC 2017


Graham, Sławek, Joshua,

Please take a look at my attempt:
https://review.openstack.org/#/c/426576/

Thanks,
Dims

On Sun, Jan 29, 2017 at 7:56 AM, Hayes, Graham <graham.hayes at hpe.com> wrote:
> On 29/01/17 00:53, Davanum Srinivas wrote:
>> Graham, Sławek,
>>
>> Have you seen this?
>>
>> Neutron has/uses a WarningFixture:
>> http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/base.py#n161
>> http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/tools.py#n70
>>
>> Which uses filterwarnings:
>> http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/tools.py#n80
>>
>> Where "always" is being used:
>> https://docs.python.org/2/library/warnings.html
>>
>> Which prints warnings every single time.
>>
>> So, can we please "fix" it in there quickly?
>>
>> Thanks,
>> Dims
>
> This is still a broken release - previously in oslo libraries we have
> been careful with issuing multiple warnings for a deprecation.
>
> This is still an issue, with glance-api [0] and I assume others (e.g. we
> have not had a designate CI run with the new oslo.context yet)
>
> Seen as we are going into RC week, it seems very risky to keep it.
>
> 0 -
> http://logstash.openstack.org/#dashboard/file/logstash.json?query=_id%3A%5C%22AVnnYuy3QVJYkPlRPEJH%5C%22
>
>> On Sat, Jan 28, 2017 at 6:46 PM, Sławek Kapłoński <slawek at kaplonski.pl> wrote:
>>> Hello,
>>>
>>> Thanks. I just filled bug report to oslo project:
>>> https://bugs.launchpad.net/oslo.context/+bug/1660088
>>>
>>> --
>>> Best regards / Pozdrawiam
>>> Sławek Kapłoński
>>> slawek at kaplonski.pl
>>>
>>> On Sat, 28 Jan 2017, Hayes, Graham wrote:
>>>
>>>> On 28/01/17 20:54, Sławek Kapłoński wrote:
>>>>> Hello,
>>>>>
>>>>> I pushed today patch in Neutron to gerrit [1] and I noticed that functional
>>>>> tests are failing. In logs there is huge number of deprecation warnings
>>>>> displayed [2]. Tests are failing because of global timeout is reached and IMO
>>>>> reason of this timeout is this huge amount of deprecation warnings.
>>>>> I checked that those warnings are disaplyed when oslo.context==2.12.0 is
>>>>> installed. With oslo.context==2.11.0 all is fine.
>>>>> Should it be reported as bug in Neutron or in Oslo project? Or maybe You
>>>>> already know about it and there is some patch to fix it but I couldn't find it?
>>>>
>>>> Its an oslo.context bug - I can't see one filed for it yet.
>>>>>
>>>>> [1] https://review.openstack.org/#/c/426429/
>>>>> [2] http://logs.openstack.org/29/426429/3/check/gate-neutron-dsvm-functional-ubuntu-xenial/7079dc5/console.html
>>>>>
>>>>
>>>> It looks like the warnings function was miss used - this should be set
>>>> as a once only message. The stack trace level seems suspect, as it
>>>> points as neutron/context.py as the one sending out the notice, not
>>>> oslo.contexts base class.
>>>>
>>>> [3] seems to the cause - I would suggest reverting this commit and
>>>> doing a 2.13.0 release. This is going to be *really* noisy. (logstash
>>>> has 2.5 million items for this string in the last 24 hours)
>>>>
>>>> 3 -
>>>> https://github.com/openstack/oslo.context/commit/f25543fcc792ebf155728a91fde06e8dc4e96cea
>>>>
>>>> __________________________________________________________________________
>>>> OpenStack Development Mailing List (not for usage questions)
>>>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Davanum Srinivas :: https://twitter.com/dims



More information about the OpenStack-dev mailing list