Open Stack

"keystoneauth1 >= 2.17.0" implies python-novaclient with your fix will
work for any version including 2.17.0 which is not true. you need to
either do "keystoneauth1 >= 2.18.0" or "keystoneauth1 > 2.17.0" and we
prefer the ">=" notation i think.

Thanks,
Dims

On Fri, Jan 20, 2017 at 10:53 PM, Kekane, Abhishek
<Abhishek.Kekane at nttdata.com> wrote:
> Hi Dims,
>
> Thank you for reply. I will propose a patch soon. Just for curiosity,
> keystoneauth1 >= 2.17.0 will not install 2.18.0?
>
> Abhishek
> ________________________________
> From: Davanum Srinivas <davanum at gmail.com>
> Sent: Saturday, January 21, 2017 8:27:56 AM
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: Re: [openstack-dev] [ python-novaclient][ python-glanceclient][
> python-cinderclient][ python-neutronclient] Remove x-openstack-request-id
> logging code as it is logged twice
>
> Abhishek,
>
> 1) requirements.txt for all 4 python-*client you mentioned have
> "keystoneauth1>=2.17.0",
> 2) i do not see a review request to bump the minimum version in global
> requirements for keystoneauth1 to "keystoneauth1>=2.18.0"
> (https://review.openstack.org/#/q/project:openstack/requirements+is:open)
>
> Can you please file one?
>
> Thanks,
> Dims
>
>
> On Fri, Jan 20, 2017 at 12:52 AM, Kekane, Abhishek
> <Abhishek.Kekane at nttdata.com> wrote:
>> Hi Devs,
>>
>>
>>
>> In the latest keystoneauth1 version 2.18.0, x-openstack-request-id is
>> logged
>> for every HTTP response. This keystoneauth1 version will be used for
>> ocata.
>>
>> The same request id is also logged in 'request' method of SessionClient
>> class for python-novaclient, python-glanceclient, python-cinderclient and
>> python-neutronclient. Once requirements.txt is synced with
>> global-requirements and it uses keystoneauth1 version 2.18.0 and above,
>> x-openstack-request-id will be logged twice for these clients.
>>
>>
>>
>> I have submitted patches for python-novaclient [1] and python-glanceclient
>> [2] and created patches for python-cinderclient and python-neutronclient
>> but
>> same will not be reviewed unless and until the requirements.txt is synced
>> with global-requirements and it uses keystoneauth1 version 2.18.0.
>>
>>
>>
>> As final releases for client libraries are scheduled in the next week
>> (between Jan 23 - Jan 27) we want to address these issues in the above
>> mentioned clients.
>>
>>
>>
>> Please let us know your opinion about the same.
>>
>>
>>
>> [1] https://review.openstack.org/422602
>>
>> [2] https://review.openstack.org/422591
>>
>>
>> ______________________________________________________________________
>> Disclaimer: This email and any attachments are sent in strictest
>> confidence
>> for the sole use of the addressee and may contain legally privileged,
>> confidential, and proprietary data. If you are not the intended recipient,
>> please advise the sender by replying promptly to this email and then
>> delete
>> and destroy this email and any attachments without any further use,
>> copying
>> or forwarding.
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> ______________________________________________________________________
> Disclaimer: This email and any attachments are sent in strictest confidence
> for the sole use of the addressee and may contain legally privileged,
> confidential, and proprietary data. If you are not the intended recipient,
> please advise the sender by replying promptly to this email and then delete
> and destroy this email and any attachments without any further use, copying
> or forwarding.
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims