Open Stack

On 1/20/17 9:05 AM, Dean Troyer wrote:
> On Fri, Jan 20, 2017 at 6:46 AM, Steve Martinelli
> <s.martinelli at gmail.com> wrote:
>> it seems the OSC gate is broken, several patches are failing the same way:
> 
> [...]
> 
>> did something break? at first glance (hehe), it seems this patch may be to
>> blame?
>> https://github.com/openstack/glance/commit/265659e8c34865331568b069fdb27ea272df4eaa
> 
> I've posted a revert of 265659e8c34865331568b069fdb27ea272df4eaa due
> to the breakage of API v1 this late in the cycle.

We've approved the revert to get the OSC unblocked, though it may be a
while before jenkins gets around to processing it, as (of course) the
gate is pretty busy now.

> 
> A couple of attempts on my part to see why the Glance unit tests did
> not catch this have fallen short due to ENO_CAFFIENE.

Even with sufficient caffeine, it's not obvious.  We didn't change the
v1 API for this (translation for v1 is being handled in the registry),
and the v1 test coverage is pretty good, so it looked like nothing was
broken.  On a closer look, the relevant v1 tests for this particular
problem check the response code, not the actual response content, so we
will beef those up a bit.

> 
> dt
>