Open Stack

Hi, @jichen:

Something I found, FYI:
The commit history in here: https://review.openstack.org/#/c/138795

I noticed that the unquience change call to cast in PS5 and PS6:
https://review.openstack.org/#/c/138795/5..6/nova/compute/rpcapi.py
and some comments on
https://review.openstack.org/#/c/138795/5/nova/compute/api.py@2235

According history comments, the reason of "use cast for unquience": it adds
_wait_for_snapshots_completion operation on unquience method in PS6,
it will cause the rpc timeout before snapshot finished if we use call rpc.

The reason of "use call for quience", I think is just quience is a short
operation, no need to change cast to call?
In the other word, call or cast is okay for quience operation, so, he
didn't change it.

Hope this helps, : )

Regards,
Yikun
----------------------------------------
Jiang Yikun（Kero）
Mail: yikunkero at gmail.com
Tel: (+86) 13572822142

2017-12-21 16:48 GMT+08:00 Chen CH Ji <jichenjc at cn.ibm.com>:

> During review https://review.openstack.org/#/c/529278/2 ,some question on
> the method for quience/unquience
>
> https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L1140
> use call for quience
> https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L1146
> use cast for unquience
>
> just curious ,any special purpose for use different type here?
>
> Best Regards!
>
> Kevin (Chen) Ji 纪 晨
>
> Engineer, zVM Development, CSTL
> Notes: Chen CH Ji/China/IBM at IBMCN Internet: jichenjc at cn.ibm.com
> Phone: +86-10-82451493 <+86%2010%208245%201493>
> Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District,
> Beijing 100193, PRC
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20171221/530448e2/attachment.html>