[openstack-dev] [nova] Suggestion about code review guide in microversion API
Takashi Natsume
natsume.takashi at lab.ntt.co.jp
Wed Aug 16 11:30:58 UTC 2017
Hi Nova Developers.
When the API microversion is bumped,
patches are required not only in nova side but also in python-novaclient
side.
But, after the nova patches were merged,
the python-novaclient patches were sometimes not submitted for a while.
The patch in python-novaclient is necessary to submit a patch for a
subsequent microversion.
For example, the patch for microversion 2.55 should be merged
after the patch for microversion 2.54 is merged.
There is a dependency between them.
So I'm proposing an amendment to the code review guide [1].
The code review guide should be changed as follows:
-----------------------------------------------------------------------------------------
A new patch for the microversion API change in python-novaclient side
should be submitted
*before the microversion change in Nova is merged*.
-----------------------------------------------------------------------------------------
[1] https://review.openstack.org/#/c/494173/
Regards,
Takashi Natsume
NTT Software Innovation Center
E-mail: natsume.takashi at lab.ntt.co.jp
More information about the OpenStack-dev
mailing list