Open Stack

On Thu, Aug 3, 2017 at 11:12 AM, Zhenyu Zheng <zhengzhenyulixi at gmail.com>
wrote:

> Hi All,
>
> Horizon provided the feature to allow user edit existing flavors, no
> matter it is currently used by any instances or not. While Nova doesn't
> provide this kind of ability, Horizon achieved this by deleting the old
> flavor first and create a new flavor with the requested properties. And the
> flavor ID will be changed to a new UUID.
>
> This causes problem when display instances with latest Nova, Horizon
> display flavor name by request flavor details using the flavor id returned
> by get_instance request, because Nova now moved flavor to api_db, and when
> a flavor got deleted, it will be directly removed from the DB, and when
> displaying, the field will be "Not Available".
>
> Should we stop support editing existing flavors? It is actually
> deleting-and-create.
>

​I do not know actual use case if this feature​ but i feel like same as you
to stop supporting this. After microversion 2.47, it would not be "Not
Available' but it will still show the flavor info where that flavor does
not exit in system anymore.
If someone refer the existing instance to use the same flavor info for
their new instance the will be confused about no such flavor exist.

Other solution might be to allow only non used flavor but that need to
iterate all existing instance and check is anyone use that flavor or not
which is more difficult after 2.47 where nova return flavor detail instead
of flavor id.


> Maybe we should  at least add WARNING notes about  this when editing
> flavors, about how it is actually done and what kind of influence will be
> to the existing instances.
>
> Nova now(> microversion 2.47) can reply embedded flavor details including
> ram, vcpus, original_name etc.
>
> Since we provided this flavor editing feature and we displayed "name" as a
> identifier, after we done some flavor edit, even we fix the above mentioned
> problem and displayed the correct flavor name, the flavor details will be
> different than the actual instance type.
>

​This also can lead to same issue of having stale flavor info in instance. ​



>
> Thoughts?
>
> BR,
>
> Kevin Zheng
>

​-gmann
​

>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170803/be5a7c38/attachment.html>