[openstack-dev] [nova] allow_instance_snapshots config option is not used consistently

Matt Riedemann mriedemos at gmail.com
Mon Apr 10 12:42:34 UTC 2017


On 4/10/2017 5:20 AM, sfinucan at redhat.com wrote:
> On Mon, 2017-04-10 at 10:24 +0100, John Garbutt wrote:
>> On 10 April 2017 at 01:56, Matt Riedemann <mriedemos at gmail.com>
>> wrote:
>>> I found a fun little legacy nugget of compute API non-
>>> interoperability joy
>>> tonight.
>>>
>>> The "allow_instance_snapshots" config option disables the
>>> createImage server
>>> action API. Completely config driven and therefore not
>>> discoverable.
>>>
>>> What intrigues me is that this isn't applied to the createBackup or
>>> shelve
>>> APIs, which also create a snapshot of the instance. Is this by
>>> design? I'm
>>> guessing probably not. In fact, this predates the use of Gerrit [1]
>>> so this
>>> was probably just something hacked in so long ago it makes zero
>>> sense now.
>>> The way to disable any of these APIs now is via policy.
>>>
>>> Unless anyone has an issue with this, I'm going to deprecate it for
>>> removal.
>>>
>>> [1]
>>> https://github.com/openstack/nova/commit/9633e9877c7836c18c30b51c84
>>> 94abfb025e64ca
>>
>> +1 for deprecate it.
>>
>> That looks like something we did before we had policy.
>> Not that policy is that discoverable yet either, but it seems better.
>>
>> Thanks,
>> john
>
> I concur. Policy seems a far better way of configuring this.
>
> Stephen
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

The question about deprecation was really just rhetorical. :)

https://review.openstack.org/#/c/455100/

-- 

Thanks,

Matt



More information about the OpenStack-dev mailing list