[openstack-dev] [nova] Is there any reason we shouldn't remove nova.image.s3 now?

Matt Riedemann mriedem at linux.vnet.ibm.com
Thu Sep 22 13:08:49 UTC 2016


On 9/22/2016 8:01 AM, Andrey Pavlov wrote:
> I've tried to do it some time ago - https://review.openstack.org/#/c/266425/
> But I tried to remove more than s3_image
> But there was no consensus...
>
> Regards,
> Andrey.
>
> On Thu, Sep 22, 2016 at 3:01 PM, Sean Dague <sean at dague.net
> <mailto:sean at dague.net>> wrote:
>
>     On 09/22/2016 02:53 AM, Clint Byrum wrote:
>     > Excerpts from Matt Riedemann's message of 2016-09-21 18:43:06 -0500:
>     >> The s3 image configuration options were deprecated for removal in newton
>     >> [1].
>     >>
>     >> Clint has a patch up to remove the boto dependency from nova [2] which
>     >> is only used in the nova.image.s3 module.
>     >>
>     >> Rather than remove the boto dependency, I think we should just remove
>     >> this code. Is there any reason to not do that now that Ocata is open and
>     >> it's been over the requisite 3 month window of deprecation for CD shops?
>     >>
>     >> [1] https://review.openstack.org/#/c/314697/
>     <https://review.openstack.org/#/c/314697/>
>     >> [2] https://review.openstack.org/#/c/374433/
>     <https://review.openstack.org/#/c/374433/>
>     >>
>     >
>     > I went ahead and updated this review to remove the code. This is
>     > definitely cleaner, and users of it can certainly resurrect it out of
>     > tree if they are in need of it.
>
>     +1 on the drop, but we should make sure to pull the related code in the
>     process. I left notes in the review for other things that can go.
>
>     The one open question to me, we've got a dedicated db table for
>     s3_images. Which, I have no idea when it was last used for anything.
>     What kind of warning do we need to do on a full table drop? Do we need
>     to handle the independently?
>
>             -Sean
>
>     --
>     Sean Dague
>     http://dague.net
>
>     __________________________________________________________________________
>     OpenStack Development Mailing List (not for usage questions)
>     Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>
>
>
>
> --
> Kind regards,
> Andrey Pavlov.
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

Yeah I think we should do this incrementally so it doesn't get out of 
control in a single change. So let's start with nova/image/s3.py and the 
configuration options, then work on the DB and object layer in a follow 
up change.

-- 

Thanks,

Matt Riedemann




More information about the OpenStack-dev mailing list