[openstack-dev] [nova] Is there any reason we shouldn't remove nova.image.s3 now?

Sean Dague sean at dague.net
Thu Sep 22 12:01:17 UTC 2016


On 09/22/2016 02:53 AM, Clint Byrum wrote:
> Excerpts from Matt Riedemann's message of 2016-09-21 18:43:06 -0500:
>> The s3 image configuration options were deprecated for removal in newton 
>> [1].
>>
>> Clint has a patch up to remove the boto dependency from nova [2] which 
>> is only used in the nova.image.s3 module.
>>
>> Rather than remove the boto dependency, I think we should just remove 
>> this code. Is there any reason to not do that now that Ocata is open and 
>> it's been over the requisite 3 month window of deprecation for CD shops?
>>
>> [1] https://review.openstack.org/#/c/314697/
>> [2] https://review.openstack.org/#/c/374433/
>>
> 
> I went ahead and updated this review to remove the code. This is
> definitely cleaner, and users of it can certainly resurrect it out of
> tree if they are in need of it.

+1 on the drop, but we should make sure to pull the related code in the
process. I left notes in the review for other things that can go.

The one open question to me, we've got a dedicated db table for
s3_images. Which, I have no idea when it was last used for anything.
What kind of warning do we need to do on a full table drop? Do we need
to handle the independently?

	-Sean

-- 
Sean Dague
http://dague.net



More information about the OpenStack-dev mailing list