[openstack-dev] [Congress] Enabling Remote Debugging

Tim Hinrichs tim at styra.com
Fri Sep 2 18:34:52 UTC 2016


I'd be concerned about merging a change to eventlet this late in the
cycle.  Threading problems are notoriously difficult to find during
testing.  I'd recommend pushing the patch to Gerrit, so that we can all try
it out when debugging, and we check it in after the Newton release.

Eric, +1 to your general advice.

I wouldn't expect a blueprint or even a bug for a code-change that only
impacts developers, unless you want to socialize the idea before writing
the code or the code is substantial.  If writing the code is small and
easy, and no one will have much to say before seeing that code, I'd just
push a patch to gerrit and see what people think.

Tim


On Fri, Sep 2, 2016 at 2:31 AM Masahito MUROI <muroi.masahito at lab.ntt.co.jp>
wrote:

> Hi Aimee,
>
> Thanks let us know.
>
> I don't think it has a big impact to the current architecture and
> user/dev. So it seems to be good to report it as a bug and target the
> fix to N-release.
>
> best regards,
> Masahito
>
> On 2016/09/02 10:10, Eric K wrote:
> > Hi Aimee,
> >
> > Thanks for digging into it!
> >
> > Here¹s my understanding of our conventions (and I¹m happy to hear from
> > others).
> >
> > a. If you think it¹s just a straightforward change with zero to minimal
> > impact on architecture, users, and devs, then it makes sense to file a
> bug
> > or just submit a patch.
> > b. If you think it warrants deeper discussion in terms of design, impact,
> > etc., then the process is to create a spec and associated blueprint. See
> > this wiki for more details:
> > https://wiki.openstack.org/wiki/Blueprints#Spec_.2B_Blueprints_lifecycle
> >
> > In case (b), the change should target the O-cycle because we¹re past
> > feature-freeze in N.
> > In case (a), it may make sense to get it in during the N-cycle if it has
> > minimal impact and will help us in the N-cycle QA process.
> >
> > My guess is we¹re in case (a) because we can make sure changes have no
> > impact without a special flag. But I¹d also like to understand a little
> > better the impact of eventlet.monkey_patch(thread=False) as done in the
> > Keystone patch (
> https://review.openstack.org/#/c/18404/3/bin/keystone-all).
> >
> > Enjoy the time holidays!
> >
> > On 9/1/16, 11:45 AM, "Aimee Ukasick" <aimeeu.opensource at gmail.com>
> wrote:
> >
> >> HI all - I've been trying to configure remote debugging with PyCharm
> >> and DevStack. It looks like some tiny modifications need to be made to
> >> the Congress code (3-4 files) to support remote debugging via pydevd.
> >>
> >> As far as I can tell, support has been added to Keystone, Glance,
> >> Nova, and Manilla (and I'm sure others).
> >>
> >> Keystone patch: https://review.openstack.org/#/c/18404/3
> >> Glance patch: https://review.openstack.org/#/c/18748/5
> >>
> >> I think it would be very beneficial to support remote debugging, and
> >> I'm willing to implement the changes needed. Should I create a bug for
> >> this or draft a blueprint?
> >>
> >> I'm out of office 2-5 Sept for the US Labor Day holiday, so I could
> >> start on this on 6 Sept.
> >>
> >> As always, I appreciate all your comments.
> >>
> >> Thanks.
> >>
> >> aimee
> >>
> >> irc:aimeeu
> >>
> >>
> __________________________________________________________________________
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> >
> >
> >
> __________________________________________________________________________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> >
>
>
> --
> 室井 雅仁(Masahito MUROI)
> Software Innovation Center, NTT
> Tel: +81-422-59-4539
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160902/c61ceefd/attachment.html>


More information about the OpenStack-dev mailing list