Open Stack

-----Original Message-----
From: Ihar Hrachyshka <ihrachys at redhat.com>
Reply: OpenStack Development Mailing List (not for usage questions) <openstack-dev at lists.openstack.org>
Date: November 8, 2016 at 11:19:42
To: OpenStack Development Mailing List (not for usage questions) <openstack-dev at lists.openstack.org>
Subject:  Re: [openstack-dev] [release] New hacking 0.12.0

> > On 8 Nov 2016, at 17:23, Ian Cordasco wrote:
> >
> >
> >
> > -----Original Message-----
> > From: Ihar Hrachyshka  
> > Reply: OpenStack Development Mailing List (not for usage questions)  
> > Date: November 8, 2016 at 02:39:24
> > To: OpenStack Development Mailing List (not for usage questions)  
> > Subject: Re: [openstack-dev] [release] New hacking 0.12.0
> >
> >>
> >>> On 7 Nov 2016, at 21:47, Ken'ichi Ohmichi wrote:
> >>>
> >>> Hi,
> >>>
> >>> Today a new hacking 0.12.0 is released.
> >>> The release contains a new hacking rule:
> >>>
> >>> [H904] Delay string interpolations at logging calls.
> >>>
> >>> BTW, the hacking repo starts containing reno since this release but it
> >>> is not used yet.
> >>> Please check the git history (or
> >>> https://review.openstack.org/#/c/343824) if wanting to know the
> >>
> >> Considering that the new check is off-by-default, and since we still have [1] unsolved,  
> >> what’s the proper procedure to consume the new check? In neutron, we are interested  
> in
> >> adopting it because then we would be able to drop our own custom check [2] that validate  
> >> the code for the same issue. But we cannot use select= in tox.ini.
> >
> > Flake8 adds an --enable-extensions option that allow you to specify the codes for the  
> off-by-default plugins. That can also be added to your tox.ini
>  
> Indeed it works, thanks! Here is neutron patch for example: https://review.openstack.org/#/c/394817/  

To be fair, the bug you linked to in pycodestyle has also been fixed by the rewrite that Flake8 did when it released 3.0. The behaviour you wanted to reach for, now just works.

That said, there appear to be some performance regressions in Flake8 itself which I'm investigating. Ideally I can get things on the right path again and start focusing on updating hacking to take advantage of Flake8 3's new features. As I'm but one person, it'll probably take some time. (Especially since this all has to happen in my free time.)

--  
Ian Cordasco