[openstack-dev] [kolla] Propose removal of TrivialFix requirement
Steven Dake (stdake)
stdake at cisco.com
Fri Nov 4 22:48:42 UTC 2016
Andreas,
Agree. Asked and answered. If Michal has some differing viewpoint, that’s his prerogative as the PTL of Kolla, however, I would have serious concerns with that model, and would request a vote of the core reviewers to solidify our processes to match the OpenStack way.
Regards
-steve
From: Andreas Jaeger <aj at suse.com>
Organization: SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
Date: Friday, November 4, 2016 at 8:30 AM
To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
Subject: Re: [openstack-dev] [kolla] Propose removal of TrivialFix requirement
On 11/04/2016 04:25 PM, Jeremy Stanley wrote:
On 2016-11-04 18:18:49 +0530 (+0530), Swapnil Kulkarni wrote:
I feel TrivialFix is consistently used by people just to avoid going
to lanuchpad and filing a bug. It should only be used only if the "Fix
is Trivial"
This has been well documented in the contributing doc [1] and this
should be referred to people when they do not have the bug/bp in the
commit message.
If the commits are important then there is no harm in creating a
tracking bug for it.
[...]
All I ask is that if the Kolla team wants to differentiate itself
from the review requirements of most OpenStack projects, please make
sure you have active and attentive liaisons who can update
mass-proposed changes for base infrastructure or other similar
horizonal and cross-project efforts to meet your special reviewing
standards. I cannot personally keep on top of the nuances of every
review team and individually adjust such mass changes myself, so
rely on you to "fix" my patches for me in such situations.
Jeremy, I do agree with your request.
I expect this to be settled by Steven Dake's email:
http://lists.openstack.org/pipermail/openstack-dev/2016-October/105287.html
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org<mailto:OpenStack-dev-request at lists.openstack.org>?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20161104/d42e1a8b/attachment.html>
More information about the OpenStack-dev
mailing list