[openstack-dev] [Nova] Abandoned old code reviews

Markus Zoeller mzoeller at linux.vnet.ibm.com
Fri May 27 11:13:40 UTC 2016


On 27.05.2016 11:36, Michael Still wrote:
> Hi,
> 
> I've spent some time today abandoning old reviews from the Nova queue.
> Specifically, anything which hadn't been updated before February this year
> has been abandoned with a message like this:
> 
> "This patch has been idle for a long time, so I am abandoning it to keep
> the review clean sane. If you're interested in still working on this patch,
> then please unabandon it and upload a new patchset."
> 
> Why do this? Abandoning the reviews means that Nova reviewers can focus on
> things where the author is still actively working on the code.
> Additionally, it makes it clearer which bugs are currently being worked.

Thanks! My script which searches for bug reports "in progress" which are
stale [1] is finding a lot more now.

> Additionally, unabandoning a review is a fairly cheap operation, so please
> let me know if I need to do that anywhere.
> 
> We should probably abandon more patches than those before February, but I
> got bored at this point. I'll probably abandon more later.
> 
> Cheers,
> Michael
> 
> 
> 
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

References:
[1]
https://github.com/markuszoeller/openstack/blob/master/scripts/launchpad/bugs_dashboard.py#L276

-- 
Regards, Markus Zoeller (markus_z)




More information about the OpenStack-dev mailing list