Open Stack

Hi Chaoyi,

Thank you for your double-check.

On Fri, May 20, 2016 at 1:12 PM, joehuang <joehuang at huawei.com> wrote:
> Hello, Shinobu,
>
> We have gate test for pep8 in the CI pipeline,

This is what I missed completely -;

Cheers,
Shinobu

> for import orders, if it's incorrect, pep8 gate check will give -1 in the result.
>
> I checked the core.py in the repository, the import order is ok, first import system level, then OSLO, then projects level with blank line between different level import
>
> https://github.com/openstack/tricircle/blob/master/tricircle/db/core.py
>
> Best Regards
> Chaoyi Huang ( Joe Huang )
>
>
> -----Original Message-----
> From: Shinobu Kinjo [mailto:shinobu.kj at gmail.com]
> Sent: Friday, May 20, 2016 11:54 AM
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: Re: [openstack-dev] [tricircle] Coding style guidelines
>
> Hi Zhipeng,
>
> Please have a look at the following script.
>
> e.g.,
> import orders.
>
> ./tricirlce/db/core.py
>
> Cheers,
> Shinobu
>
>
> On Fri, May 20, 2016 at 12:41 PM, Zhipeng Huang <zhipengh512 at gmail.com> wrote:
>> Hi shinobu, could you provide an example of which part of code need
>> modification to fit the guideline ?
>>
>> On Fri, May 20, 2016 at 11:04 AM, Shinobu Kinjo <shinobu.kj at gmail.com>
>> wrote:
>>>
>>> Hi Team,
>>>
>>> Please make sure that your coding style follows OpenStack style
>>> guidelines. [1]
>>>
>>> I understand that it's really painful but readability, and
>>> maintenanceability point of view, it is very important to follow
>>> standard.
>>>
>>> Working through code bases, some of them do not follow the guidelines.
>>> Please read the guide line.
>>>
>>> Thank you for your understanding.
>>>
>>> [1] http://docs.openstack.org/developer/hacking/
>>>
>>> Cheers,
>>> S
>>>
>>> --
>>> Email:
>>> shinobu at linux.com
>>> shinobu at redhat.com
>>>
>>> _____________________________________________________________________
>>> _____ OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>>
>>
>> --
>> Zhipeng (Howard) Huang
>>
>> Standard Engineer
>> IT Standard & Patent/IT Prooduct Line
>> Huawei Technologies Co,. Ltd
>> Email: huangzhipeng at huawei.com
>> Office: Huawei Industrial Base, Longgang, Shenzhen
>>
>> (Previous)
>> Research Assistant
>> Mobile Ad-Hoc Network Lab, Calit2
>> University of California, Irvine
>> Email: zhipengh at uci.edu
>> Office: Calit2 Building Room 2402
>>
>> OpenStack, OPNFV, OpenDaylight, OpenCompute Aficionado
>>
>> ______________________________________________________________________
>> ____ OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
> --
> Email:
> shinobu at linux.com
> shinobu at redhat.com
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Email:
shinobu at linux.com
shinobu at redhat.com