[openstack-dev] [nova]Libvirt error code for failing volume in nova

Silvan Kaiser silvan at quobyte.com
Thu May 19 08:56:08 UTC 2016

Regarding 1. I'd start with giving a generic message, e.g. "error while
attaching volume" that does not point to a specific reason.
Regarding 2., if the reason is identifiable throwing the corresponding
exception would come in handy. Only use the generic failure if there's no
specific error knowledge.
I'm hitting that bug, too, great to see it addressed! :)
Best regards

2016-05-18 21:57 GMT+02:00 Radhakrishnan, Siva <siva.radhakrishnan at intel.com

> Hi All!
> Currently I am working on this bug
> https://bugs.launchpad.net/nova/+bug/1168011 which says we have to
> change  error message displayed  when attaching a volume fails. Currently
> it catches all operation errors that libvirt can raise and assume that all
> of them are the source of device being busy. You can find the source of
> this code here
> https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1160.
> I have few questions on this bug
> 1.      what kind of error message and other required info should we
> include in the exception to make it look more      generalized instead of
> the current one ?
> 2.      Should we raise separate exception for "Device is Busy" or a
> single general exception would work fine ?
> 3.      If we need separate exception for device being busy what would be
> the equivalent libvirt error code  for that
> I would like to have your feedback/suggestions to proceed further with
> this bug.
> Regards,
> Siva
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Dr. Silvan Kaiser
Quobyte GmbH
Hardenbergplatz 2, 10623 Berlin - Germany
+49-30-814 591 800 - www.quobyte.com<http://www.quobyte.com/>
Amtsgericht Berlin-Charlottenburg, HRB 149012B
Management board: Dr. Felix Hupfeld, Dr. Björn Kolbeck, Dr. Jan Stender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160519/7a9fef92/attachment.html>

More information about the OpenStack-dev mailing list