https://github.com/bbangert/routes/pull/65 On Tue, Mar 29, 2016 at 9:04 PM, Henry Gessau <HenryG at gessau.net> wrote: > https://launchpad.net/bugs/1563028 > https://review.openstack.org/298855 > > Aditya Vaja <wolverine.av at gmail.com> wrote: >> Hi, >> >> I'm seeing unit test failures when I test locally after a fresh git clone of >> neutron master. >> >> $ ./run_tests.sh -V -f >> >> log excerpt: http://paste.openstack.org/show/492384/ >> >> I update the requirements.txt to use 'Routes<2.0,>=1.12.3' and all the tests >> work fine. >> I see there was a new release (v2.3 ) of Routes on 28th March 2016 [1], which >> seems to have caused the issue, specifically: >> - Concatenation fix when using submappers with path prefixes. Multiple >> submappers combined the path prefix inside the controller argument in >> non-obvious ways. The controller argument will now be properly carried through >> when using submappers. PR #28[2]. >> >> Is anyone else noticing the test failures? >> Should I submit this requirements.txt change as a patch or should we pass the >> required two args as the patch? I can do the requirement.txt change. For the >> latter, somebody who knows what goes on in the extensions.py __init__() should >> take a look. >> >> I assume this will also affect the stable branches, since the Routes package >> versin in requirements.txt in previous versions was same as in master. >> >> -- >> Aditya >> [1] https://routes.readthedocs.org/en/latest/changes.html#release-2-3-march-28-2016 >> [2] https://github.com/bbangert/routes/pull/28/files?diff=unified#diff-b54de741c3f86d76eb4bce4a223054aaL154 > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims