Open Stack

Hi Na,

Please see inline for my reply.

Cathy

-----Original Message-----
From: Na Zhu (Code Review) [mailto:review at openstack.org] 
Sent: Monday, June 27, 2016 8:08 PM
To: Henry Fourie
Cc: Ryan Moats; Na Zhu; Kyle Mestery; Russell Bryant; Richard Theis; Stephen Wong; Cathy Zhang; Vikram Choudhary; Farhad Sunavala; John McDowall
Subject: Change in openstack/networking-sfc[master]: Networking-sfc / OVN Driver

Na Zhu has posted comments on this change.

Change subject: Networking-sfc / OVN Driver ......................................................................


Patch Set 1:

(1 comment)

https://review.openstack.org/#/c/333172/1/doc/source/sfc_ovn_driver.rst
File doc/source/sfc_ovn_driver.rst:

Line 88:     +---------+       +---------+ outport +===========+
> Agree that it is better to clarify these points. 
Hi Cathy,
I try to create multiple port-chains with the same port-pair-group, it failed. I think it is not allowed to do what you said, right?
(neutron) port-chain-create --flow-classifier fc --port-pair-group pg1 pc1 Port Pair Group(s) [u'17c9a0a5-a38f-4a75-834e-9aa213cd431f'] in use by Port Chain f3af530f-210a-4c51-9a02-f1835d5b1d85.
Neutron server returns request_ids: ['req-47e6a39b-677a-4ce3-9976-5dfcee0ac47f']
(neutron)

Cathy> when a port pair group is shared by multiple chains, these chains should be different, which means these chains should consist of different sequences of port pair groups. For example, chain 1 consists of <port-pair-group1, port-pair-group2> and chain 2 consists of "port-pair-group1, port-pair-group3, port-pair-group4>. But if the two chains are the same, i.e. they consist of the same sequence of port-pair-groups (e.g. the two chains both consist of <port-pair-group1>), then it is not allowed since it does not make sense to create the same chain twice. Maybe your test scenario falls into the second case?



-- 
To view, visit https://review.openstack.org/333172
To unsubscribe, visit https://review.openstack.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1827dcc81e48983a41120ec08983c571c5b2e9
Gerrit-PatchSet: 1
Gerrit-Project: openstack/networking-sfc
Gerrit-Branch: master
Gerrit-Owner: Louis Fourie <louis.fourie at huawei.com>
Gerrit-Reviewer: Farhad Sunavala <fsbiz at yahoo.com>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: John McDowall <jmcdowall at paloaltonetworks.com>
Gerrit-Reviewer: Kyle Mestery <mestery at mestery.com>
Gerrit-Reviewer: Louis Fourie <louis.fourie at huawei.com>
Gerrit-Reviewer: Na Zhu <nazhu at cn.ibm.com>
Gerrit-Reviewer: Richard Theis <rtheis at us.ibm.com>
Gerrit-Reviewer: Russell Bryant <rbryant at redhat.com>
Gerrit-Reviewer: Ryan Moats <rmoats at us.ibm.com>
Gerrit-Reviewer: Stephen Wong <stephen.kf.wong at gmail.com>
Gerrit-Reviewer: cathy <cathy.h.zhang at huawei.com>
Gerrit-Reviewer: vikram.choudhary <vikram.choudhary at huawei.com>
Gerrit-HasComments: Yes