[openstack-dev] [Neutron][LBaaS][Octavia]In amphora plugin_vip(), why cidr and gateway are required but not used?

Jiahao Liang jiahao.liang at oneconvergence.com
Tue Jun 21 17:53:09 UTC 2016


Thank you the info Lubosz.

On Fri, Jun 17, 2016 at 5:01 PM, Kosnik, Lubosz <lubosz.kosnik at intel.com>
wrote:

> Here is a bug for that - https://bugs.launchpad.net/octavia/+bug/1585804
> You’re more than welcome to fix this issue.
>
> Lubosz Kosnik
> Cloud Software Engineer OSIC
> lubosz.kosnik at intel.com
>
> On Jun 17, 2016, at 6:37 PM, Jiahao Liang <jiahao.liang at oneconvergence.com>
> wrote:
>
> Added more related topics to the original email.
>
> ---------- Forwarded message ----------
> From: Jiahao Liang (Frankie) <gzliangjiahao at gmail.com>
> Date: Fri, Jun 17, 2016 at 4:30 PM
> Subject: [openstack-dev][Octavia]In amphora plugin_vip(), why cidr and
> gateway are required but not used?
> To: openstack-dev at lists.openstack.org
>
>
> Hi community,
>
> I am going over the Octavia amphora backend code. There is one thing
> really confused me. In
> https://github.com/openstack/octavia/blob/stable/mitaka/octavia/amphorae/backends/agent/api_server/plug.py#L45,
> plug_vip() method doesn't use the cidr and gateway from the REST request.
> But in the haproxy amphora api, those two fields are required values (an
> assert
> <https://github.com/openstack/octavia/blob/stable/mitaka/octavia/amphorae/backends/agent/api_server/server.py#L117> will
> perform on the server).
>
> What is the design considerations for this api? Could we safely remove
> these two values to avoid ambiguity?
>
> Thank you,
> Jiahao Liang
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160621/10bf9946/attachment.html>


More information about the OpenStack-dev mailing list