[openstack-dev] [Neutron][LBaaS][Octavia]In amphora plugin_vip(), why cidr and gateway are required but not used?

Jiahao Liang jiahao.liang at oneconvergence.com
Fri Jun 17 23:37:56 UTC 2016


Added more related topics to the original email.

---------- Forwarded message ----------
From: Jiahao Liang (Frankie) <gzliangjiahao at gmail.com>
Date: Fri, Jun 17, 2016 at 4:30 PM
Subject: [openstack-dev][Octavia]In amphora plugin_vip(), why cidr and
gateway are required but not used?
To: openstack-dev at lists.openstack.org


Hi community,

I am going over the Octavia amphora backend code. There is one thing really
confused me. In
https://github.com/openstack/octavia/blob/stable/mitaka/octavia/amphorae/backends/agent/api_server/plug.py#L45,
plug_vip() method doesn't use the cidr and gateway from the REST request.
But in the haproxy amphora api, those two fields are required values (an
assert
<https://github.com/openstack/octavia/blob/stable/mitaka/octavia/amphorae/backends/agent/api_server/server.py#L117>
will
perform on the server).

What is the design considerations for this api? Could we safely remove
these two values to avoid ambiguity?

Thank you,
Jiahao Liang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160617/d097ba42/attachment.html>


More information about the OpenStack-dev mailing list