Open Stack

15.06.2016 0:51, Matt Riedemann пишет:

> It was pointed out today in IRC that the Virtuozzo CI has been failing 
> on this change for the libvirt imagebackend refactor:
>
> https://review.openstack.org/#/c/282580/
>
> Diana was having a hard time sorting out the line numbers in the stack 
> trace though from the logs, because they didn't exist in her series.
>
> Long story short, that's because the job checks to see if the change 
> is the change that adds resize support for virtuozzo:
>
> https://review.openstack.org/#/c/182257/
>
> And if not, it fetches that change:
>
> 23:48:46 2016-06-10 23:48:58.863 | + cd /opt/stack/new/nova
> 23:48:46 2016-06-10 23:48:58.872 | + [[ 282580 -ne 182257 ]]
> 23:48:46 2016-06-10 23:48:58.875 | + git fetch 
> https://review.openstack.org/p/openstack/nova refs/changes/57/182257/37
> 23:48:59 2016-06-10 23:49:11.357 | From 
> https://review.openstack.org/p/openstack/nova
> 23:48:59 2016-06-10 23:49:11.359 |  * branch refs/changes/57/182257/37 
> -> FETCH_HEAD
> 23:48:59 2016-06-10 23:49:11.366 | + git cherry-pick FETCH_HEAD
> 23:48:59 2016-06-10 23:49:11.689 | [detached HEAD 44b6772] libvirt: 
> virtuozzo instance resize support
>
> It's not valid to patch Nova for your CI when testing other changes, 
> it breaks the whole point of CI testing if you have to patch things in 
> it that aren't in the actual dependency change or repo - because when 
> it fails, like in this case, one doesn't know if it's their actual 
> change that's broken or the patch in the CI job.
>
> I'm assuming this was done because I asked for the Virtuozzo CI to run 
> the resize tests in tempest against 
> https://review.openstack.org/#/c/182257/ - which it is, but that 
> didn't mean also do it for all other changes in Nova. The CI job 
> should conditionally enable those tests when testing change 182257 but 
> not anything else until that's merged.
>
> As a side note, the job isn't fetching the latest patch set of the 
> resize change anyway, at least not as of last week, it's fetching 
> patch set 37 but 39 is the latest.
>
> Anyway, this isn't meant to shame, but to inform and correct. No one 
> from the Virtuozzo team was in the nova IRC channel when we discovered 
> this, so I needed to get it into the dev list.
>
> But please get this fixed ASAP since it's invalidating the Virtuozzo 
> CI results.
>

Hi Matt,

I just want to inform you and all involved and/or affected that we are 
fixing the issue. Sorry for inconvenience.
I'll update you as soon as we resolve this problem.

Maxim