[openstack-dev] [Neutron] [sr-iov] rename *device* config options to *interface*

Andreas Scheuring scheuran at linux.vnet.ibm.com
Mon Jun 13 08:22:06 UTC 2016

While reviewing [1] I got hung up on the terms "device" and "interface".
It seems like in sr-iov agent they are used in a different manner than
in the linuxbridge agent. 

For Example the lb agent uses a config option
"physical_interface_mappings" (mapping between uplink interface for
bridge and physnet). A similar option in the sr-iov agent is named
"physical_device_mappings" (mapping between PF and physnet -> missing in
config reference for some reason [2]). In the l2 agent context, a
variable named device typically references to a port specific device
(e.g. the tap device) and not to a shared host device (like eth0). 

As now patchset [1] introduces a new agent extension for lb & ovs agent
including a new config option "shared_physcial_device_mappings", I
really got a bit confused during the review as now in lb context
"device" is something different (namely a physical interface).

Would it make sense rename all the sr-iov options from *device* to
*interface* to stay consistent and to have a clear separation between
port specific and shared host devices?

My proposal is to name
- shared host device: interface
- port specific devices: device

[1] https://review.openstack.org/320562
[2] https://bugs.launchpad.net/openstack-manuals/+bug/1591906

IRC: andreas_s (formerly scheuran)

More information about the OpenStack-dev mailing list