[openstack-dev] [tricircle] reviewed by multiple eyes

joehuang joehuang at huawei.com
Mon Jun 6 00:49:50 UTC 2016


There are several articles will be helpful both to reviewers and code contributors: [1],[2],[3]

[1]:  http://docs.openstack.org/infra/manual/developers.html#code-review
[2]:  http://docs.openstack.org/infra/manual/developers.html#peer-review
[3]:  https://krotscheck.net/2015/07/13/code-review-in-openstack.html

I think this point is quite important for reviewer: Be explicit: If you ask for a change, specify where that change needs to be made, how it needs to be made, and why it needs to be made. Provide a code example if possible. 

Best Regards
Chaoyi Huang ( Joe Huang )

-----Original Message-----
From: Shinobu Kinjo [mailto:shinobu.kj at gmail.com] 
Sent: Friday, June 03, 2016 7:28 PM
To: OpenStack Development Mailing List (not for usage questions)
Subject: [openstack-dev] [tricircle] reviewed by multiple eyes

Hi Team,

There are some patch sets reviewed by only myself.
>From my point of view, any patch set needs to be reviewed by multiple eyes.

It's because anyone is not perfect. And there should be anything missing.
Please take a look, if you get notification to review.


shinobu at linux.com
shinobu at redhat.com

OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe

More information about the OpenStack-dev mailing list