Open Stack

On 7/29/2016 12:32 PM, Sean Dague wrote:
> On 07/28/2016 05:38 PM, Matt Riedemann wrote:
>> On 7/28/2016 3:55 PM, Matt Riedemann wrote:
>>> For os-attach-interfaces, we need that to attach/detach interfaces to a
>>> server, so those actions don't go away with 2.36. We can also list and
>>> show interfaces (ports) which is a proxy to neutron, but in this case it
>>> seems a tad bit necessary, else to list ports for a given server you
>>> have to know to list ports via neutron CLI and filter on
>>> device_id=server.uuid.
>>
>> On second thought, we could drop the proxy APIs to list/show ports for a
>> given server. python-openstackclient could have a convenience CLI for
>> listing ports for a server. And the show in os-attach-interfaces takes a
>> server id but it's not used, so it's basically pointless and should just
>> be replaced with neutron.
>>
>> The question is, as these are proxies and the 2.36 microversion was for
>> proxy API deprecation, can we still do those in 2.36 even though it's
>> already merged? Or do they need to be 2.37? That seems like the more
>> accurate thing to do, but then we really have some weird "which is the
>> REAL proxy API microversion?" logic going on.
>>
>> I think we could move forward with deprecation in novaclient either way.
>
> We should definitely move forward with novaclient CLI deprecations.
>
> We've said that microversions are idempotent, so fixing one in this case
> isn't really what we want to do, it should just be another bump, with
> things we apparently missed. I'm not sure it's super important that
> there is a REAL proxy API microversion. We got most of it in one go, and
> as long as we catch the stragglers in 2.39 (let's make that the last
> merged one before the release so that we can figure out anything else we
> missed, and keep get me a network as 2.37).
>
> 	-Sean
>

That works for me.

I'm on the fence about deprecating os-virtual-interfaces, it would 
actually work for both nova-network and neutron now since for neutron 
we're now also creating VirtualInterface records in the nova database.

If it were just nova-network, it would be a no-brainer since that's 
deprecated and going away. But it could be a useful API still if we 
updated it to return VIF tags (added in 2.32). It wouldn't be a proxy to 
Neutron, we could literally pull up the nova.network.api code into 
nova.network.base_api to make that work (but it would need a new 
microversion).

At this point that kind of change would be an Ocata thing, but deciding 
what to do about it depends on how we treat the virtual-interface-list 
CLI in novaclient.

-- 

Thanks,

Matt Riedemann