Open Stack

Gary Kotton <gkotton at vmware.com> wrote:
> commit https://github.com/openstack/neutron/commit/5d53dfb8d64186b5b1d2f356fbff8f222e15d1b2 may
> break the decomposed plugins that make use of the method _get_tenant_id_for_create

Note that this is a private method. Plugins should avoid using private
methods. Unfortunately during the decomposition efforts not enough effort was
expended on scrubbing private methods from the plugins. This should be
something that plugin maintainers continue to work on and keep an eye out for.

> It would have been nice if there was a deprecation warning.

I don't think we should have deprecation warnings for private properties.

> Options:
> 
>  1. Decomposed plugins fix this
>  2. Revert the patch and find a solution that does not break the plugins
> 
> If we do go for #1 then we can start to stop enforcing the usage of the
> deprecation warnings…

We will continue to use deprecation warnings for changes to non-private
methods affecting plugins.