Open Stack

Hi.

We have a followed transition in common/states.py:

# An errored instance can be rebuilt
# ironic/conductor/manager.py:do_node_deploy()
machine.add_transition(ERROR, DEPLOYING, 'rebuild')

At first glance it looks correct. But ERROR state is
used only for error after deleting, see
http://docs.openstack.org/developer/ironic/_images/states.svg
So ERROR is delete error, at least now, and transition
error (delete error) -> deploying (on_rebuild)
is possible.
Looks strange if operator wants to remove an instance completely and then
does rebuild after error (non-error targets for deleting is cleaning -> 
available).
I think this transition should be removed. Without this strange transition
bug https://bugs.launchpad.net/ironic/+bug/1522008 can be fixed by 
simple way,
port's vif id can be removed via Ironic virt driver request before 
waiting of CLEANING
(it's no more needed).

Yuriy Zveryanskyy