[openstack-dev] [all] Adding CONTRIBUTING.rst files to projects

Zhenyu Zheng zhengzhenyulixi at gmail.com
Thu Dec 22 05:20:53 UTC 2016


Agreed with Amrith, it might be useful and maybe also good for new
contributors to learn how to have a commit to OpenStack. BUT over 130
identical patches to 130 different projects from one company/person in one
run? I don't think this is going to help OpenStack growing. We should not
let this happen.

On Thu, Dec 22, 2016 at 12:44 AM, Amrith Kumar <amrith at tesora.com> wrote:

> For those who would like to know exactly what this set of changes cost in
> the CI, the answer is approximately 1050 jobs which consumed 190 compute
> hours of CI time.
>
> -amrith
>
> -----Original Message-----
> From: Amrith Kumar [mailto:amrith at tesora.com]
> Sent: Wednesday, December 21, 2016 11:13 AM
> To: OpenStack Development Mailing List (not for usage questions) <
> openstack-dev at lists.openstack.org>
> Subject: Re: [openstack-dev] [all] Adding CONTRIBUTING.rst files to
> projects
>
> Ian, Andreas, Emilien,
>
> My sentiments on the subject of these kinds of "production line" changes
> is unchanged from [1] and [2]. A complete list of these changes is at [3].
>
> I've updated all of the changes in this thread with a block comment and a
> -1. My apologies to other reviewers (and active contributors in those
> projects) for this automated comment across 131 commits.
>
> It is high time we eliminated these kinds of changes which do little to
> improve the overall quality of the product and serve merely to generate a
> huge amount of pointless work on the CI systems, and boost some meaningless
> statistics that someone wants to put on a slide someplace.
>
> -amrith
>
> [1] http://openstack.markmail.org/thread/dsuxy2sxxudfbij4
> [2] http://openstack.markmail.org/thread/3sr5c2u7fhpzanit
> [3] https://review.openstack.org/#/q/topic:addCONTRIBUTING.rst
>
> -----Original Message-----
> From: Andreas Jaeger [mailto:aj at suse.com]
> Sent: Wednesday, December 21, 2016 10:47 AM
> To: OpenStack Development Mailing List (not for usage questions) <
> openstack-dev at lists.openstack.org>
> Subject: Re: [openstack-dev] [all] Adding CONTRIBUTING.rst files to
> projects
>
> On 2016-12-21 16:22, Ian Cordasco wrote:
> > [...]
> > That said, I think there are two better places for this information
> > that are already standards in OpenStack:
> >
> > * README.rst
> > * HACKING.rst
> >
> > Most projects include links to the contributing documentation in at
> > least one of these files. I think the effort here is to standardize,
> > albeit in a brand new file, and that's admirable.
>
> If that's the goal - to standardize - then I would expect that we move all
> the documentation out of those files in one place.
>
> Right now, the changes duplicate information that exists - and the new
> information is often wrong. It points to place that do not exist or where
> better places exist. ;(
>
>
> I'm fine with the status quo - of using the two files that you mention.
> Having contribution information is important,
>
> Andreas
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>    GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>        HRB 21284 (AG Nürnberg)
>     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20161222/19efdd80/attachment.html>


More information about the OpenStack-dev mailing list