[openstack-dev] [neutron][ipam] max_fixed_ips_per_port

Gary Kotton gkotton at vmware.com
Wed Aug 31 11:51:54 UTC 2016


I posted https://review.openstack.org/363602 . The deprecation of a mitaka release note was silly.
So please let me know what you guys think.

I think that keeping the configuration variable is the sanest option. Implementing a callback in each and every plugin that wants to enforce this is a overkill.


From: Gary Kotton <gkotton at vmware.com>
Reply-To: OpenStack List <openstack-dev at lists.openstack.org>
Date: Wednesday, August 31, 2016 at 2:36 PM
To: OpenStack List <openstack-dev at lists.openstack.org>
Subject: [openstack-dev] [neutron][ipam] max_fixed_ips_per_port

Hi,
In commit 37277cf4168260d5fa97f20e0b64a2efe2d989ad [i] and commit fc661571765054ff09e41aa6c7fc32f80fd0a98d [ii] this variable was marked as deprecated. A number of neutron plugins make use of this to ensure that only one IP address can be configured per port per subnet. There are cases where the DHCP implementations only enabled one MAC:IP mapping. So this makes life very simple for us by setting a configuration variable.
The deprecations and possible removal in N, O or P could cause issues.
Would it be possible to do one of the two options:

1.      revert the two patches below with the deprecation warnings [iii]

2.      Or add a callback that would enable plugins to add their own validation logic (I need to push a patch if the option above is a no go.
Thanks
Gary

[i] https://github.com/openstack/neutron/commit/37277cf4168260d5fa97f20e0b64a2efe2d989ad
[ii] https://github.com/openstack/neutron/commit/fc661571765054ff09e41aa6c7fc32f80fd0a98d<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openstack_neutron_commit_fc661571765054ff09e41aa6c7fc32f80fd0a98d&d=CwMGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=VlZxHpZBmzzkWT5jqz9JYBk8YTeq9N3-diTlNj4GyNc&m=Af6UOHgaTOGJAY8p5_gvzPiY3VKAO2OW6r7DgYkGDJ8&s=ESCtRhUFKao9MKVGSvD7-U4_eyfFK8ue4wP-n5hteJs&e=>
[iii] https://review.openstack.org/#/c/363599/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160831/0acb15fc/attachment.html>


More information about the OpenStack-dev mailing list