Open Stack

On 8/29/2016 6:27 AM, tiendc at vn.fujitsu.com wrote:
> Hi Matt, Dan, Andrew,
>
> @Matt: Hope you had a nice vacation.
>
> For the feature Nova serial console support for Ironic [1][2], there are some good update from Ironic side. All our Ironic-side works [3][4][5] have been done, currently there is only the nova patch that needs to review.
>
> Last week, I contacted Andrew and Dan for reviewing it. But both Andrew and Dan said they didn't notice you've removed -2 from the patch. So, Matt, can you notify the Nova core team about that so Andrew and Dan can review it again?
>
> [1] https://blueprints.launchpad.net/nova/+spec/ironic-serial-console-support
> [2] https://review.openstack.org/#/c/328157/  (Nova patch, in review)
> [3] https://review.openstack.org/#/c/319505/  (Ironic spec, merged)
> [4] https://review.openstack.org/#/c/328168/  (Ironic patch, merged)
> [5] https://review.openstack.org/#/c/293873/  (Ironic patch, merged)
>
> Thanks and Regards
> TienDC
>
> -----Original Message-----
> From: Matt Riedemann [mailto:mriedem at linux.vnet.ibm.com]
> Sent: Thursday, July 07, 2016 3:16 AM
> To: openstack-dev at lists.openstack.org
> Subject: Re: [openstack-dev] [nova] Non-priority feature freeze and FFEs
>
> On 7/5/2016 2:14 AM, tiendc at vn.fujitsu.com wrote:
>> Hi folks,
>>
>> I want to give more information about our nova patch for bp ironic-serial-console-support. The whole feature needs work to be done in Nova and Ironic. The nova bp [1] has been approved, and the Ironic spec [2] has been merged.
>>
>> This nova patch [3] is simple, we got some reviews by some Nova and Ironic core reviewers. The depended patches in Ironic are [4][5] which [4] will get merged soon and [5] is in review progress.
>>
>> Hope Nova core team considers adding this case to the exception list.
>>
>> [1]
>> https://blueprints.launchpad.net/nova/+spec/ironic-serial-console-supp
>> ort  (Nova bp, approved by dansmith) [2]
>> https://review.openstack.org/#/c/319505/  (Ironic spec, merged)
>>
>> [3] https://review.openstack.org/#/c/328157/  (Nova patch, in review)
>> [4] https://review.openstack.org/#/c/328168/  (Ironic patch 1st, got
>> two +2, will get merged soon) [5]
>> https://review.openstack.org/#/c/293873/  (Ironic patch 2nd, in
>> review)
>>
>> Thanks and Regards
>> Dao Cong Tien
>>
>>
>
> When I looked last week the nova change was dependent on multiple ironic patches which weren't merged yet, so it wasn't ready to go for the non-priority feature freeze. The ironic changes are all merged yet either when we were going over FFE candidates. So this is going to have to wait for Ocata.
>

Sorry, the -2 removal was a mistake, that happened when I removed myself 
as a reviewer from that change since I wasn't actively reviewing it but 
it kept changing, so I wanted to turn off the email noise I was getting 
from it.

I've re-applied the -2 on 328157 since we're long past non-priority 
feature freeze and the normal feature freeze is this week (9/1) and need 
to focus on closing out priority work.

-- 

Thanks,

Matt Riedemann